From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756405AbdABPaR (ORCPT ); Mon, 2 Jan 2017 10:30:17 -0500 Received: from mail-eopbgr40136.outbound.protection.outlook.com ([40.107.4.136]:11168 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755682AbdABPaN (ORCPT ); Mon, 2 Jan 2017 10:30:13 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Subject: Re: [PATCH v6 7/9] i2c: i2c-mux-simple: new driver To: Andy Shevchenko References: <1480493823-21462-1-git-send-email-peda@axentia.se> <1480493823-21462-8-git-send-email-peda@axentia.se> Cc: "linux-kernel@vger.kernel.org" , Wolfram Sang , Rob Herring , Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Corbet , Arnd Bergmann , Greg Kroah-Hartman , linux-i2c@vger.kernel.org, devicetree , linux-iio@vger.kernel.org, Linux Documentation List From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <49bbe0f9-8cf7-c932-265e-ebab39bc2a1e@axentia.se> Date: Mon, 2 Jan 2017 16:30:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [217.210.101.82] X-ClientProxiedBy: AM5PR0601CA0031.eurprd06.prod.outlook.com (10.173.86.145) To HE1PR0201MB2315.eurprd02.prod.outlook.com (10.168.145.150) X-MS-Office365-Filtering-Correlation-Id: 8860d445-c754-49aa-8d7a-08d433243c5a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR0201MB2315; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0201MB2315;3:zHbS4QSreAEXxde3pXV0vAJEcsJWp/cVRBi2kogEms+2A2y+Q5Dmy5WnMr8ck4apB7k6dCyJ9c0aQ9FZUMnJEr73nsOyH+LIVXNDli/6HvGWPNzhiZMeTz1af8ydSDnXhr/ouMQYyIuJLl82Rr8MLh9SCrZAYasCg7IhksoX3wAg0/RmRbvE23+stPGwlTAwSkmm93Ij7eFszwVKvyoha2bj937a1/u/ffa7ex25YXvfhKgis2GWLcUF5W/DxjWe5mP5zaepOMjwJHVZFVjKgQ== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0201MB2315;25:AxYstfiHuf/pNKIuRvHq9/fSEcQfxvTKoUoLXONcNw1datJPMj5TqCz3Bekr1aVM2FQSARLJfrzvVp5ghnnevVEmQZWt+DqMezz0krGL1/lwEYpYRM+LQMW0bUyBcztsiXMzzcgeDZWbeTG0JWK3Wc46uj2swZzdaQE4p1XcGXdOIQLl1qNGB3bTxHBftK/U091WOeASftsckD+om+NGeh5uUDZqTtePwuJC8Zx4ErlX+OgvlXpWe12zBHJd4rM0N8ydroT5fg65ESuoljp6H14SubcarKQQLMpeLU5mLiGYEIsKpW1E1PVCrq26JJXYDwNALe4Ad9snVcc94lLLZOxNUoJXpJmxxQL/6ddWQdk51nOCVc7E1jKKJmugxAHtP4ujmASHzERSGiGbyLn0lrlvR251rr7X20WTyLIMI15xzZrZGdYERA5MAYL0Tx3/mvBb9+Fg6SVPGenjMtcXvUQvSAYW9KM6Vjfvh56ywS29uxNFgHN40KpfWed1UpddSsoNCOYC5NaFQvv3Su4orxdQTt2L9C7+sleNqU2G/OWjRLRBr9IFOViyVRyFt9Aar+InkgtpfywVb9gP+HJFmhhmvEWddgo1NuJgcmyvy4yCKdMPLuMGcOkucafry/LqNCWNb+8vc08vIXupYHO9yhlq5hgpyfEYPDsS9jBtTtHenRk993X/Hzu9UQXY9Cjk8aXV/r6eCcSC7qeO2OF1QXVjmRJBssozzxRlRDAHD1M= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0201MB2315;31:qsWppLpf217zGjB2XOMuF6A+faHxFQvEpE/3kNdTJY3f9Zw+HEWl7si95/YBThcDn19XRdCBZ7BSMkgvotm7/0D2AA/cBd3o0MD4oPk4hGnunVTaWWLbYQoCUJiXJWtt7gSuxDKJ5YLLT0uaf36KPIukDXnTQHEwgyWhQmJT5rcntvPStauqx1uHBgnf1JxLJutqu/NMLJHDMyAmzfw4kWaiGI2jcjRQ4Lyni3nbo5zMV1YiOwyGGTQxgaeGugBGRkYNKzqcG2lQCOVy/OKrqYF7xHggwYmMrGvgTrvbmE0=;4:RccoMZPzsJouC8+jNw765/jDwR+vOk5zTBcAMRwPZ1HT9lf3aM2hQdsvxHD1RZvuJX2xXCLC671zdZVlRm+KzGjZ9E9BShL9kMAwc2S8Noa/ONnd0r2af013N3BBtSHj8qwysUDaFL/54kZmWmFA7DFiKmGRZ/u/jthjbvvS9iP2V71Q9YaAcLtRlO4jmASadX7IMQMJJD3wMs5fG7myB77qdrOjgpwQ+Pk02yA3p+LnCqY31Q2Sd/JXZontc+ET+2J8cyiRDl6lp1O51fQMoULKbTOSo7YGYUcKwlpQtR+KMvwIMk0D5/L3xUdJg4LMT6pqQnHFCj9i9xv25ryplyJnm6d7mfC8861gqc+HiHOm9erDU+g6swQiOgZ6sxfRo2nH5GFMwhnNTnqmm0NSo/sK0Xv2x7UxKguTexFQCMTAxCBrr/0UG7S7RtGeHgFZ+ba94ytWbSvuUdgAwQ0tzds6wTdWPtzxEfDZAhVd5ZgQ3luib18KAkAZenocl56b/AmwpZiHP/Zf391OzaW9iNEMZIayeX9QC/afMLmkC89WdUg+ljocz2Bnzts9B4pAKic9OTNUws4K2HMf9/DFF/yDijm0ad1e63Y0NfZNFh0Zoj5izlOEi0rxdCz3+lHs X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(2016111802025)(6072148)(6043046);SRVR:HE1PR0201MB2315;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0201MB2315; X-Forefront-PRVS: 017589626D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(39450400003)(39410400002)(39830400002)(377424004)(377454003)(189002)(199003)(24454002)(90366009)(101416001)(117156001)(4001350100001)(97736004)(3846002)(54356999)(77096006)(230783001)(8676002)(6116002)(50986999)(2906002)(47776003)(74482002)(110136003)(65806001)(65956001)(7416002)(66066001)(36756003)(83506001)(76176999)(7736002)(6916009)(23676002)(86362001)(68736007)(2950100002)(81156014)(81166006)(65826007)(305945005)(64126003)(33646002)(6666003)(31696002)(39060400001)(5660300001)(92566002)(106356001)(50466002)(189998001)(54906002)(105586002)(229853002)(8666007)(25786008)(6486002)(4326007)(31686004)(42186005)(230700001)(38730400001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0201MB2315;H:[192.168.0.125];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjAyMDFNQjIzMTU7MjM6MkxzSGJncmZoOFQvcnZqZEdQbldldWpR?= =?utf-8?B?aE5JdkQ3eGJ4VEVVQnRGR3NMQnQ2SFlQYTF3Y3NQQ0gzbmdyeUloWWQrSE5T?= =?utf-8?B?VnFkaVRpVitNakovbWFlUFNkZDBXc1RtOThBRlV3a2QwWGVlVTlVL2xaRGM1?= =?utf-8?B?TENLdVBuVEZyMS85aCtiYUpHekxyWENRb1c3dWJCWkc3MERRVXVtbXYrMy90?= =?utf-8?B?ZHJjSnEvc1h4cC9NODBGTWszdjRYOS9uTU1FOGdtd1N5RXhHUUVjUDY3SjBq?= =?utf-8?B?cVJQNjhpRXZCTUlSN21md0Z5ZVp6Q1k2M2RqdDFaeFdqaFZ2eXY2UjRoNTRs?= =?utf-8?B?R2JuaURkckY5d2NjVE85Yi9mblNUL3JtcE93YTlHV3VVMVJpZzBUWEF0Rytv?= =?utf-8?B?bnh5dERkUUNQNGljbXU1b2c5c2dsajdNTUptTXdwK3FyNmNhWldvL1RiYTl5?= =?utf-8?B?ZVpheXRlcVRRSCtLMk5yV0FDeityc3F0ZmZpY21DdHplVkRCRzRKYTNoeWI3?= =?utf-8?B?amxOci9ISTRESU4yNlNjOGVVUnZIcWlMRVViL1VCOVN3Zk9MNGc2K0YzWjlD?= =?utf-8?B?Y21qd3RYaHVJbWpOQlhqNjR0THlpTEFoMy96REdwdXgxck8wRFNKWE1sRXhR?= =?utf-8?B?cStkanNWOW9lOFNUd2NiS3lFZE5FNGgvZDhuRGZ1T1YxZ21YOTJ1VUQ4amxt?= =?utf-8?B?RHBXUmNVMi9yTTNjN2c4WFZvbG1JK3AwNnJCeUlJdTl6SVlBVGJzWTNWVDF1?= =?utf-8?B?OHdkVWpCTUp2NkQvZDNGSmRhZkVzZVR4NVM3NHE1djg5UVpua3YwQjBIcGZh?= =?utf-8?B?SXl3YXQ5akd1MlVqazJzdVMvTGplTVpKSFV2NGRuT3A2S0E5RFlKbnN3b2ZD?= =?utf-8?B?QlJuTGpNTEZibWVqNyt4V3IvcUdjWElQUjY2d0ZkTFA2ZEd4ZHBLQ0NINEdn?= =?utf-8?B?dStCWk1DZjFFZnMwaFgyR1hEbXVjdGY3dFF1UWp0a2dRcllLSWFtY2g3STli?= =?utf-8?B?d3VMdllXUDBHMHRTak84TmVRVDhYamVmbW1UemdGU2x4R2RaSk5rR09ZRFhJ?= =?utf-8?B?QitiZTRwYmxmOGt2bTB2dFNLclA0ZHo3TjZxczNpM1JvS1g4SEw3MXQ5UGR0?= =?utf-8?B?UHllQmNsRVhFVE5KRTdiMjRhWjZWZU9OeUN0SG05Z2wwb0ZUQVNkd09oWlFO?= =?utf-8?B?NGNwTFRRNGVZODNQMk9FK2pyUzZVbUNmVUNLK1hSbDhXMDlHcmd2YUw0ZEZy?= =?utf-8?B?MGxweEVCeStFcE4yQVM5THFFNnBjTUtIK2toM1NRdGZMUURrT0h3NHdqcE5V?= =?utf-8?B?eEVFZSt4TGtsYUFFYTFYenlCc0o1Y2JoKzNEYWNSS0l2MkVhN3NQejlzRkg5?= =?utf-8?B?cDdpc1d4NzdPR3lXb1QxNUFDZlFteFFrZTZVYWJ6R1lQcTR4dkVmc1AzMEFJ?= =?utf-8?B?dFVES0JXQ2t2STB6N256andkNmdFZUdLSzl1cklIcHU1Z1g4VE0zMk01NzA3?= =?utf-8?B?dWFZQmhYMnptc1JtbFJxVFptRDFvaVdiVlQ5Mjl4eXZTVkpXaTBEcTJ4Q3pC?= =?utf-8?B?QWI2cnQ1VExFamhuRXNKUm1NUk5uTzZsUFovSzZKNStEYW1oMWJDUEFwKzND?= =?utf-8?B?VERxQ1Vkcm9JNmhqeDMzbmF4d0J4SkVYbnBuZGVMRWFWeU16R0xnOXM4Rmxr?= =?utf-8?B?enlIOHB6OVd1TVdjTTBldHJwVTBmYjZ4WHJGZVdrVlVDc2M0ZUpONWtoeExs?= =?utf-8?B?YXplZjI0bDlUZ1Voem9sVFFpaExNZ0FWSkJsU1cyMlE3cTZ6WDY3Q0REenZ1?= =?utf-8?B?NWI3WEdjOVZ6OUlPaUtBM3pMWjVLNmhEZHM3YXhNeUVWbmtENXZTVmw2b2tJ?= =?utf-8?B?WnlHV2RwNkE2SGZGKzJMdys1Uk1YYmRBNXl2UVdOZlk5QVpNbXZzZTZUM045?= =?utf-8?B?Q09tUUtPdGcrRUNMME9PdHp2QnloOEY3dE1sd2VjbXRRM0VVN1NRdUpuMyto?= =?utf-8?B?T005K3luQ3AxYUhJTlUrQXNtc2tQZC9ySkNFZU5jRXlXUCtCSFE3Y2gwZFp1?= =?utf-8?B?QzdpcGFNL0FwYlBIZFRsMThnZEwrNmJuY25KRkc5dzlOcm5FbTN5dmwrSE1I?= =?utf-8?Q?xzBOpAapmbq/Lk3zWC02jTnEE5ndlpAhUePzkUW4biZLAL?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0201MB2315;6:A6tYXx7XXhHL1U0c/p0GTru46upIEmPbeNxjSAqjogvOk8q2cMMl0vrnBwOFw7DUkGuSGHCxth7lcAb2uoUcndCazMutFBLLLKO9AEvkcwkX97vP8vWXLgOm2fWpPiTkgD/za5YwOBFIxnUfdYuwCa9viQY7mp+3lylaKKLTavfd9eio6Q55E+gylfHCDyNDL6SOg3q0HwZ0Q9sFOgs5WUqpns9bpGstfZfH/dK3hlXTeILnDJ5yBp7l7D81nPDeW+CBRyJ3YhQm6HQA2oWsFUjrt01aiykM68BcGf+8ze4KOGxUBGt9aI6Azw4goUtupQF+WysRGlbIqjCRwUwXAheYpZ9q8rvyh7retA6E45ZjdZITsuAS1Mo2Qbr6jan/nlzz2PvmWwBje0TTzXCTTY/Nk+L6/7SPp/1+yNh1KU/mYywOc6r/rnUh0taRUQCs;5:MIc4zNAWGF78G+yuBPiMJmzDT9DbhhcN1S+Ejiv5wk6X/KHq+GECVFxlPBQB+MFAezFhvC7wSsJREL1o3FlsDrr5DYqHh+itzRsvhWxy220ABc2OmNtztQcBxqnq3V4uhr4qzAy/e4CZMT6AFCaVzg==;24:zbmfp1tfF5JNfLcaHqUbAltJAFifGR0ajXxpi++l9XQS65bm3YZlZyvRWTghSSFSYYNu0HaHEVM92Wy1xCIpN6NsRUTymgi4z3FKZKfxMXk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0201MB2315;7:ey1sqJK4GzxFJ+ecAsAAK/qhgGf5vcOUpuOA33A9IQoJ9MqhPpaO8xkDlEdOoGb0sy0y+evMPh2YlgwAj7XFlU0QClnRdbDxnem7wCLnxSwbKbmbWWfiitWa4Zs9tS6gtcPQYMuO3sVzVXcygEPZqp7lRLPUlv/qzj3cG54gPz66WzkYvd4GRshytiqw2nvU5sFtMgqmTI8vXF961JLJjoH0VbqdBpfMzvhnTASs918gmd57EmUwX6LJAL3cIfIPYYAne6WtsXaoZZgZ+XNqUHtenb74bhVRUgeSZ48CsH8e9hQFivPC587ThGWEJlxJj0k99OYwDnU1vbs6NKMqelvWoYLfZeEG9D8VWNY2FZpFv9347D99HtUAmGxS+4B8suECBRZWJgToPSUpf++liYw5BgK06s7gLwcmlMbLj3mIlbsu21+cFHTKWY+Ycb7sIGF+Fz1eqnDRoY8mXBPmjQ== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2017 15:30:07.1603 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0201MB2315 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-01-01 16:38, Andy Shevchenko wrote: > On Wed, Nov 30, 2016 at 10:17 AM, Peter Rosin wrote: >> This is a generic simple i2c mux that uses the generic multiplexer >> subsystem to do the muxing. > >> +static const struct of_device_id i2c_mux_of_match[] = { >> + { .compatible = "i2c-mux-simple,parent-locked", >> + .data = (void *)0, }, >> + { .compatible = "i2c-mux-simple,mux-locked", >> + .data = (void *)1, }, >> + {}, >> +}; > > Perhaps > > #define I2C_MUX_LOCKED_PARENT 0 > #define I2C_MUX_LOCKED 1 I2C_MUX_LOCKED is already "taken" in include/linux/i2c-mux.h but I'll use SIMPLE_PARENT_LOCKED and SIMPLE_MUX_LOCKED instead. Cheers, peda