From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B500DC433E0 for ; Tue, 5 Jan 2021 20:12:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A4A922D5A for ; Tue, 5 Jan 2021 20:12:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728507AbhAEUMo (ORCPT ); Tue, 5 Jan 2021 15:12:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:42760 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726605AbhAEUMn (ORCPT ); Tue, 5 Jan 2021 15:12:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609877477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9lHUJ5BbT3/c3BacIKOhpQG6gVZEznCUigJp41xFTx4=; b=DsyJ8EIQt1uNC+OSLfA7GzykRp7sdK/tMW+8Cgd+XT0dI+oQ+Y9HR5+ipx5yvfxHNnrNvA W6FUn7Urts89RciD1VN/wMfV09tTQao2G8cfP+sxD7sYTJQFmSCw09WA8wyV7QYPo7S/8a 9pIoBYruSHhq3eBO6cRi3dlgB3LGtkc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458-pLySCTB8O5mF_ok-1ZACSw-1; Tue, 05 Jan 2021 15:11:13 -0500 X-MC-Unique: pLySCTB8O5mF_ok-1ZACSw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 80594DBBD; Tue, 5 Jan 2021 20:11:10 +0000 (UTC) Received: from ovpn-115-104.rdu2.redhat.com (ovpn-115-104.rdu2.redhat.com [10.10.115.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 679751002393; Tue, 5 Jan 2021 20:11:07 +0000 (UTC) Message-ID: <49be27f2652d4658f80c95bea171142c35513761.camel@redhat.com> Subject: Re: [PATCH v21 00/19] per memcg lru lock From: Qian Cai To: Shakeel Butt Cc: Alex Shi , Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Matthew Wilcox , Johannes Weiner , kernel test robot , Linux MM , LKML , Cgroups , Joonsoo Kim , Wei Yang , "Kirill A. Shutemov" , alexander.duyck@gmail.com, kernel test robot , Michal Hocko , Vladimir Davydov , Yang Shi Date: Tue, 05 Jan 2021 15:11:06 -0500 In-Reply-To: References: <1604566549-62481-1-git-send-email-alex.shi@linux.alibaba.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2021-01-05 at 11:42 -0800, Shakeel Butt wrote: > On Tue, Jan 5, 2021 at 11:30 AM Qian Cai wrote: > > On Thu, 2020-11-05 at 16:55 +0800, Alex Shi wrote: > > > This version rebase on next/master 20201104, with much of Johannes's > > > Acks and some changes according to Johannes comments. And add a new patch > > > v21-0006-mm-rmap-stop-store-reordering-issue-on-page-mapp.patch to support > > > v21-0007. > > > > > > This patchset followed 2 memcg VM_WARN_ON_ONCE_PAGE patches which were > > > added to -mm tree yesterday. > > > > > > Many thanks for line by line review by Hugh Dickins, Alexander Duyck and > > > Johannes Weiner. > > > > Given the troublesome history of this patchset, and had been put into linux- > > next > > recently, as well as it touched both THP and mlock. Is it a good idea to > > suspect > > this patchset introducing some races and a spontaneous crash with some mlock > > memory presume? > > This has already been merged into the linus tree. Were you able to get > a similar crash on the latest upstream kernel as well? No, I seldom test the mainline those days. Before the vacations, I have tested linux-next up to something like 12/10 which did not include this patchset IIRC and never saw any crash like this. I am still trying to figure out how to reproduce it fast, so I can try a revert to confirm.