From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D099CC433DB for ; Thu, 7 Jan 2021 19:34:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89426235DD for ; Thu, 7 Jan 2021 19:34:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729307AbhAGTdo (ORCPT ); Thu, 7 Jan 2021 14:33:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729217AbhAGTdo (ORCPT ); Thu, 7 Jan 2021 14:33:44 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE128C0612F4; Thu, 7 Jan 2021 11:33:03 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id o17so17327280lfg.4; Thu, 07 Jan 2021 11:33:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vxUip14RHVX/OnxxwbLmc0hVz7ijR2h5m5MRiT/bCAE=; b=a2fTOP8+Sw7uFzLwIHNPQPdw9SBnjjOYW0iyQO9mY99jrwJgS0BotesqRsiXc/Oa7y TxbfpgYRY5wJ/wUZ0sjQvoT5iWMZHYJIzxzbmxpDeD4EJIJ+upIGUY5GDja59hgUFp6R sxdJ2eQ+hPi6RQPM91nGwFXyRgvYDpxyd6pq1s/kJcVF5GiGvOKVYrTz5dZkaIZcXsIH 9q0BXX/l4A8k4z3Cc3rK4LZld0x6DNSIzGZ5p+FANkYq9y4xxPVn4KEoD/UjfoxcK4jY irVwOaRdax8RX/Mg/clSYEDs5zOmfJCWL5ogALItAzrJxRtAzpyk2idSHRyQFidp9Y/L gP6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vxUip14RHVX/OnxxwbLmc0hVz7ijR2h5m5MRiT/bCAE=; b=fhkSQ/3YtjrymdCQiuRh1pPLRMUS0ucSdt+Mw8B/w0dxoz40plkdHxDnQxsunH3eJf g59rkSlWU75ln0v2ylY3CX5BjdaKSL0N0az/irz1Al8tn5yFiT2VTAeZ60g6a7KwlUB2 Jz4sXKm0/Ua5GNVcEsRWwWM/DfeP2MERTqtnSIPKfZmMtTdfXpTJN7dhFsogVpx6snUY vCRnrC6NGkzYHNWbwstojKsiwPjEXCaPB0ZGbCZpg/IjB+QfQRHhMzqapS5kOgBKB6GF SQKJRVaYyAfC3HHE9RogE3XAgeyUaB/thgSL1xlInKejFdLh9NWFk0ELHaobeWGolKfk pJuQ== X-Gm-Message-State: AOAM531KcbYT9azleoUCkSEDlwi5ePfqn14zdJ8mH5vmy2qxSXiVQGaH SsCxbRzzMlpRdTit+ET5E0xSkNn3R6M= X-Google-Smtp-Source: ABdhPJwFmIgqOwxg/9mqqNTGbKZ765Zo2UcnYWWDC9ReW7Hi1/+lK4w+7lv34DtC/EwPZsVvTlNyPA== X-Received: by 2002:a05:6512:4cf:: with SMTP id w15mr116805lfq.656.1610047981344; Thu, 07 Jan 2021 11:33:01 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id a23sm1332780lfm.125.2021.01.07.11.33.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jan 2021 11:33:00 -0800 (PST) Subject: Re: [PATCH] usb: dwc3: Replace of_reset_control_array_get() To: Yejune Deng , balbi@kernel.org, gregkh@linuxfoundation.org, p.zabel@pengutronix.de Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <1604395500-8086-1-git-send-email-yejune.deng@gmail.com> From: Dmitry Osipenko Message-ID: <49ee0444-4e0f-1dbe-c59a-74c72b34b140@gmail.com> Date: Thu, 7 Jan 2021 22:33:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <1604395500-8086-1-git-send-email-yejune.deng@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 03.11.2020 12:25, Yejune Deng пишет: > of_reset_control_array_get_optional_exclusive() looks more readable > > Signed-off-by: Yejune Deng > --- > drivers/usb/dwc3/dwc3-of-simple.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c > index e62ecd2..e358ff0 100644 > --- a/drivers/usb/dwc3/dwc3-of-simple.c > +++ b/drivers/usb/dwc3/dwc3-of-simple.c > @@ -52,8 +52,7 @@ static int dwc3_of_simple_probe(struct platform_device *pdev) > if (of_device_is_compatible(np, "rockchip,rk3399-dwc3")) > simple->need_reset = true; > > - simple->resets = of_reset_control_array_get(np, false, true, > - true); > + simple->resets = of_reset_control_array_get_optional_exclusive(np); > if (IS_ERR(simple->resets)) { > ret = PTR_ERR(simple->resets); > dev_err(dev, "failed to get device resets, err=%d\n", ret); > Reviewed-by: Dmitry Osipenko