From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753512AbZK1AwT (ORCPT ); Fri, 27 Nov 2009 19:52:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752365AbZK1AwS (ORCPT ); Fri, 27 Nov 2009 19:52:18 -0500 Received: from bhuna.collabora.co.uk ([93.93.128.226]:37962 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751586AbZK1AwS (ORCPT ); Fri, 27 Nov 2009 19:52:18 -0500 Message-ID: <4B10741C.9090305@collabora.co.uk> Date: Sat, 28 Nov 2009 00:51:40 +0000 From: Ian Molton User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707) MIME-Version: 1.0 To: Matt Mackall CC: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au, jeff@garzik.org, Herbert Xu Subject: rng updates References: <1259197403.2858.88.camel@calx> <1259232570-11918-1-git-send-email-ian.molton@collabora.co.uk> <1259235525.9212.444.camel@calx> <4B0E6B02.8020705@collabora.co.uk> <1259362496.25403.165.camel@calx> In-Reply-To: <1259362496.25403.165.camel@calx> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matt Mackall wrote: > On Thu, 2009-11-26 at 11:48 +0000, Ian Molton wrote: >> Matt Mackall wrote: >>> On Thu, 2009-11-26 at 10:49 +0000, Ian Molton wrote: >>>> Hi guys, >>>> >>> No need to pass rng_buffer to the helper as there's only one with global >>> scope. >> Ah, sorry, I see what you mean now. The logic behind that is that it >> matches the new API, whcih is all that will be left once the old drivers >> are patched to use it. I planned to drop the helper altogether at that >> point and though it'd make the patch more readable when that happens. > > Ok, that's quite reasonable. > >> Is this enough to get an acked-by: ? If so, I'll do that and see about >> getting the change into linux-next. > > Acked-by: Matt Mackall Just to check - is that with or without changing the helpers parameters? > You should probably go through Herbert's tree to get into -next, > hopefully he won't be too miffed by your repeated failure to cc: > linux-kernel initially and failure to cc: him here.. Drat, I thought he'd been re-added when LKML got added to the CC: list. Sorry about that. Re-added to CC: -Ian