From: "Helight.Xu" <helight.xu@gmail.com>
To: Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: mingo@elte.hu, peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: Memory leak in two error corner cases
Date: Thu, 10 Dec 2009 10:39:47 +0800 [thread overview]
Message-ID: <4B205F73.90704@gmail.com> (raw)
In-Reply-To: <1260380746-4856-1-git-send-email-ext-phil.2.carmody@nokia.com>
Phil Carmody wrote:
> From: Phil Carmody <ext-phil.2.carmody@nokia.com>
>
> If the second in each of these pairs of allocations fails, then
> the first one will not be freed in the error route out.
>
> Found by a static code analysis tool.
>
> Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
> ---
> kernel/sched.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched.c b/kernel/sched.c
> index e7f2cfa..29ebc4a 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -9841,8 +9841,10 @@ int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
>
> se = kzalloc_node(sizeof(struct sched_entity),
> GFP_KERNEL, cpu_to_node(i));
> - if (!se)
> + if (!se) {
> + kfree(cfs_rq);
> goto err;
> + }
>
if here has menory leak, why not here!
tg->cfs_rq = kzalloc(sizeof(cfs_rq) * nr_cpu_ids, GFP_KERNEL);
if (!tg->cfs_rq)
goto err;
tg->se = kzalloc(sizeof(se) * nr_cpu_ids, GFP_KERNEL);
if (!tg->se)
goto err;
should I fix here?
>
> init_tg_cfs_entry(tg, cfs_rq, se, i, 0, parent->se[i]);
> }
> @@ -9929,8 +9931,10 @@ int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
>
> rt_se = kzalloc_node(sizeof(struct sched_rt_entity),
> GFP_KERNEL, cpu_to_node(i));
> - if (!rt_se)
> + if (!rt_se) {
> + kfree(rt_rq);
> goto err;
> + }
>
> init_tg_rt_entry(tg, rt_rq, rt_se, i, 0, parent->rt_se[i]);
> }
>
--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org
next prev parent reply other threads:[~2009-12-10 2:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 17:45 [PATCH] sched: Memory leak in two error corner cases Phil Carmody
2009-12-09 17:54 ` Peter Zijlstra
2009-12-10 2:39 ` Helight.Xu [this message]
2009-12-10 5:12 ` Peter Zijlstra
2009-12-10 8:02 ` Ingo Molnar
2009-12-10 12:29 ` [PATCH] [v2] " Phil Carmody
2009-12-10 13:37 ` [tip:sched/urgent] sched: Fix memory " tip-bot for Phil Carmody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B205F73.90704@gmail.com \
--to=helight.xu@gmail.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).