From: Robert Hancock <hancockrwd@gmail.com>
To: Seth Heasley <seth.heasley@intel.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.32.3] ahci: AHCI and RAID mode SATA patch for Intel Cougar Point DeviceIDs
Date: Tue, 12 Jan 2010 22:40:10 -0600 [thread overview]
Message-ID: <4B4D4EAA.2010109@gmail.com> (raw)
In-Reply-To: <201001121700.18234.seth.heasley@intel.com>
On 01/12/2010 07:00 PM, Seth Heasley wrote:
> This patch adds the Intel Cougar Point (PCH) SATA AHCI and RAID Controller DeviceIDs.
>
> Signed-off-by: Seth Heasley<seth.heasley@intel.com>
>
> --- linux-2.6.32.3/drivers/ata/ahci.c.orig 2010-01-06 15:07:45.000000000 -0800
> +++ linux-2.6.32.3/drivers/ata/ahci.c 2010-01-07 13:55:23.000000000 -0800
> @@ -560,6 +560,12 @@
> { PCI_VDEVICE(INTEL, 0x3b2b), board_ahci }, /* PCH RAID */
> { PCI_VDEVICE(INTEL, 0x3b2c), board_ahci }, /* PCH RAID */
> { PCI_VDEVICE(INTEL, 0x3b2f), board_ahci }, /* PCH AHCI */
> + { PCI_VDEVICE(INTEL, 0x1c02), board_ahci }, /* CPT AHCI */
> + { PCI_VDEVICE(INTEL, 0x1c03), board_ahci }, /* CPT AHCI */
> + { PCI_VDEVICE(INTEL, 0x1c04), board_ahci }, /* CPT RAID */
> + { PCI_VDEVICE(INTEL, 0x1c05), board_ahci }, /* CPT RAID */
> + { PCI_VDEVICE(INTEL, 0x1c06), board_ahci }, /* CPT RAID */
> + { PCI_VDEVICE(INTEL, 0x1c07), board_ahci }, /* CPT RAID */
>
> /* JMicron 360/1/3/5/6, match class to avoid IDE function */
> { PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
The RAID mode entries would be needed if the device indicates RAID class
in that mode, but in plain AHCI mode it should indicate SATA AHCI class
which will get picked up by this catch-all so those entries shouldn't be
needed:
/* Generic, PCI class code for AHCI */
{ PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff, board_ahci },
Likely a lot of the existing specific PCI IDs could be removed from the
driver because of this (many likely predate the addition of the
class-based catch-all). The only reason to need a specific entry if the
device uses AHCI class is if it needs special handling or workarounds,
which isn't the case here.
next prev parent reply other threads:[~2010-01-13 4:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 1:00 [PATCH 2.6.32.3] ahci: AHCI and RAID mode SATA patch for Intel Cougar Point DeviceIDs Seth Heasley
2010-01-13 4:40 ` Robert Hancock [this message]
2010-01-13 11:11 ` Jeff Garzik
2010-01-13 14:59 ` David Milburn
2010-01-13 15:43 ` Heasley, Seth
2010-01-14 0:03 ` Robert Hancock
2010-01-13 15:15 ` Krzysztof Halasa
2010-01-13 17:08 ` Jeff Garzik
2010-01-13 18:18 ` Krzysztof Halasa
2010-01-13 23:57 ` Robert Hancock
2010-01-14 14:40 ` Krzysztof Halasa
2010-01-15 0:15 ` Robert Hancock
2010-01-15 21:43 ` Krzysztof Halasa
2010-01-16 1:32 ` Robert Hancock
2010-01-16 18:02 ` Krzysztof Halasa
2010-01-14 0:11 ` Robert Hancock
2010-01-14 0:42 ` Robert Hancock
2010-01-14 20:11 ` Henrique de Moraes Holschuh
2010-01-15 0:15 ` Robert Hancock
2010-01-16 3:02 ` Henrique de Moraes Holschuh
2010-01-16 4:57 ` Robert Hancock
2010-01-20 3:21 ` Tejun Heo
2010-01-14 15:40 ` Krzysztof Halasa
2010-01-20 19:28 ` Jeff Garzik
[not found] ` <201009090944.56546.seth.heasley@intel.com>
2010-09-10 23:38 ` [PATCH 2.6.35.4] ahci: AHCI and RAID mode SATA patch for Intel Patsburg DeviceIDs Seth Heasley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4D4EAA.2010109@gmail.com \
--to=hancockrwd@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seth.heasley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).