From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755439Ab0ANCxX (ORCPT ); Wed, 13 Jan 2010 21:53:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755248Ab0ANCxV (ORCPT ); Wed, 13 Jan 2010 21:53:21 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:55071 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755312Ab0ANCxU (ORCPT ); Wed, 13 Jan 2010 21:53:20 -0500 Message-ID: <4B4E8721.5090301@cn.fujitsu.com> Date: Thu, 14 Jan 2010 10:53:21 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Ingo Molnar CC: Steven Rostedt , Frederic Weisbecker , LKML Subject: [PATCH 2/7] tracing/filters: Fix MATCH_FRONT_ONLY filter matching References: <4B4E86FB.40208@cn.fujitsu.com> In-Reply-To: <4B4E86FB.40208@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org MATCH_FRONT_ONLY actually is a full matching: # ./perf record -R -f -a -e lock:lock_acquire \ --filter 'name ~rcu_*' sleep 1 # ./perf trace (no output) We should pass the length of the pattern string to strncmp(). Signed-off-by: Li Zefan Acked-by: Frederic Weisbecker --- kernel/trace/trace_events_filter.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c index 74563d7..6d7b8f5 100644 --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c @@ -261,7 +261,7 @@ static int regex_match_full(char *str, struct regex *r, int len) static int regex_match_front(char *str, struct regex *r, int len) { - if (strncmp(str, r->pattern, len) == 0) + if (strncmp(str, r->pattern, r->len) == 0) return 1; return 0; } -- 1.6.3