From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756251Ab0ANMvq (ORCPT ); Thu, 14 Jan 2010 07:51:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756017Ab0ANMvq (ORCPT ); Thu, 14 Jan 2010 07:51:46 -0500 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:35393 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755593Ab0ANMvo (ORCPT ); Thu, 14 Jan 2010 07:51:44 -0500 X-Greylist: delayed 744 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Jan 2010 07:51:44 EST X-Sasl-enc: gl/IMtp9E1Fz4YH6G6OJarzhSytGLzYuk9fRsJ7Ujunc 1263472759 Message-ID: <4B4F1073.5060903@imap.cc> Date: Thu, 14 Jan 2010 13:39:15 +0100 From: Tilman Schmidt User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.1.7) Gecko/20100104 SeaMonkey/2.0.2 MIME-Version: 1.0 To: Andi Kleen CC: Alan Cox , Greg KH , Stephen Rothwell , LKML , netdev@vger.kernel.org, Karsten Keil , isdn4linux@listserv.isdn4linux.de Subject: Re: Can we remove pci_find_device() yet? References: <20100108112236.462a3da2.sfr@canb.auug.org.au> <20100108044646.GC6611@suse.de> <4B4B802A.2010709@imap.cc> <20100111200136.GA29955@suse.de> <877hrlf0rf.fsf@basil.nowhere.org> <20100114110214.37d7ffc9@lxorguk.ukuu.org.uk> <20100114110354.GJ12241@basil.fritz.box> In-Reply-To: <20100114110354.GJ12241@basil.fritz.box> X-Enigmail-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2010-01-14 12:03 schrieb Andi Kleen: > On Thu, Jan 14, 2010 at 11:02:14AM +0000, Alan Cox wrote: [It would be better to enforce this constraint at runtime.] >> There is a simpler way to do that, which is to just leak a reference in >> the hisax_find_pci_device hack. The pci_dev won't be going anywhere then. > > You just have to do it once, otherwise it'll fail after 4 billion times. I guess we could live with that. pci_find_device() or its successor, the hisax_find_pci_device() hack, is only called during device setup, once for most drivers and at the very most 24 times for hfc_pci. Someone would have to rmmod/insmod a HiSax module more than a hundred million times to accumulate four billion calls. - -- Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAktPEHMACgkQQ3+did9BuFuQ/gCgkhu6RJIwrpIDAJMWbO1mZgOd BKwAnAh6kX5F/+dFPIrK/XLovEAv/R7O =fflE -----END PGP SIGNATURE-----