From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61929C43441 for ; Wed, 14 Nov 2018 10:31:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F2B72086A for ; Wed, 14 Nov 2018 10:31:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F2B72086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aosc.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732841AbeKNUeR convert rfc822-to-8bit (ORCPT ); Wed, 14 Nov 2018 15:34:17 -0500 Received: from hermes.aosc.io ([199.195.250.187]:33238 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727883AbeKNUeQ (ORCPT ); Wed, 14 Nov 2018 15:34:16 -0500 Received: from localhost (localhost [127.0.0.1]) (Authenticated sender: icenowy@aosc.io) by hermes.aosc.io (Postfix) with ESMTPSA id 76DA7A289B; Wed, 14 Nov 2018 10:30:38 +0000 (UTC) Date: Wed, 14 Nov 2018 18:30:24 +0800 In-Reply-To: References: <20181004122855.22981-1-icenowy@aosc.io> <20181004122855.22981-5-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [linux-sunxi] [PATCH v4 04/10] arm64: allwinner: dts: h6: add USB2-related device nodes To: Chen-Yu Tsai CC: Rob Herring , Maxime Ripard , Kishon Vijay Abraham I , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi@googlegroups.com From: Icenowy Zheng Message-ID: <4B5BD39B-22E2-4DEA-A199-29094DB8C317@aosc.io> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2018年11月14日 GMT+08:00 下午6:21:33, Chen-Yu Tsai 写到: >Hi, > >On Thu, Oct 4, 2018 at 8:30 PM Icenowy Zheng wrote: >> >> Allwinner H6 has two USB2 ports, one OTG and one host-only. >> >> Add device tree nodes related to them. >> >> Signed-off-by: Icenowy Zheng >> Reviewed-by: Chen-Yu Tsai >> --- >> No changes in v4. >> >> Changes in v3: >> - Removed the wrongly introduced usb3phy node. >> - Added Chen-Yu's Review tag. >> >> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 81 >++++++++++++++++++++ >> 1 file changed, 81 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi >b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi >> index 040828d2e2c0..3d60af6cb3ae 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi >> @@ -258,6 +258,87 @@ >> status = "disabled"; >> }; >> >> + usb2otg: usb@5100000 { >> + compatible = "allwinner,sun8i-a33-musb"; > >I added an SoC-specific compatible: "allwinner,sun50i-h6-musb". > >I'm also curious as to whether the MUSB controller was tested or not, >since Allwinner now has EHCI/OHCI host pairs for host mode, and the >Pine H64 >only does host mode. USB plug-in detection relays on MUSB if it's enabled. > >> + reg = <0x05100000 0x0400>; >> + clocks = <&ccu CLK_BUS_OTG>; >> + resets = <&ccu RST_BUS_OTG>; >> + interrupts = IRQ_TYPE_LEVEL_HIGH>; >> + interrupt-names = "mc"; >> + phys = <&usb2phy 0>; >> + phy-names = "usb"; >> + extcon = <&usb2phy 0>; >> + status = "disabled"; >> + }; >> + >> + usb2phy: phy@5100400 { >> + compatible = "allwinner,sun50i-h6-usb-phy"; >> + reg = <0x05100400 0x14>, >> + <0x05101800 0x4>, >> + <0x05311800 0x4>; >> + reg-names = "phy_ctrl", >> + "pmu0", >> + "pmu3"; >> + clocks = <&ccu CLK_USB_PHY0>, >> + <&ccu CLK_USB_PHY3>; >> + clock-names = "usb0_phy", >> + "usb3_phy"; >> + resets = <&ccu RST_USB_PHY0>, >> + <&ccu RST_USB_PHY3>; >> + reset-names = "usb0_reset", >> + "usb3_reset"; >> + status = "disabled"; >> + #phy-cells = <1>; >> + }; >> + >> + ehci0: usb@5101000 { >> + compatible = "allwinner,sun50i-h6-ehci", >"generic-ehci"; >> + reg = <0x05101000 0x100>; >> + interrupts = IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ccu CLK_BUS_OHCI0>, >> + <&ccu CLK_BUS_EHCI0>, >> + <&ccu CLK_USB_OHCI0>; >> + resets = <&ccu RST_BUS_OHCI0>, >> + <&ccu RST_BUS_EHCI0>; >> + status = "disabled"; >> + }; >> + >> + ohci0: usb@5101400 { >> + compatible = "allwinner,sun50i-h6-ohci", >"generic-ohci"; >> + reg = <0x05101400 0x100>; >> + interrupts = IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ccu CLK_BUS_OHCI0>, >> + <&ccu CLK_USB_OHCI0>; >> + resets = <&ccu RST_BUS_OHCI0>; >> + status = "disabled"; >> + }; >> + >> + ehci3: usb@5311000 { >> + compatible = "allwinner,sun50i-h6-ehci", >"generic-ehci"; >> + reg = <0x05311000 0x100>; >> + interrupts = IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ccu CLK_BUS_OHCI3>, >> + <&ccu CLK_BUS_EHCI3>, >> + <&ccu CLK_USB_OHCI3>; >> + resets = <&ccu RST_BUS_OHCI3>, >> + <&ccu RST_BUS_EHCI3>; >> + phys = <&usb2phy 3>; >> + phy-names = "usb"; >> + status = "disabled"; >> + }; >> + >> + ohci3: usb@5311400 { >> + compatible = "allwinner,sun50i-h6-ohci", >"generic-ohci"; >> + reg = <0x05311400 0x100>; >> + interrupts = IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ccu CLK_BUS_OHCI3>, >> + <&ccu CLK_USB_OHCI3>; >> + resets = <&ccu RST_BUS_OHCI3>; >> + phys = <&usb2phy 3>; >> + phy-names = "usb"; >> + status = "disabled"; >> + }; >> + > >This didn't apply cleanly due to the new HDMI nodes. I fixed it up >locally. > >ChenYu > >> r_ccu: clock@7010000 { >> compatible = "allwinner,sun50i-h6-r-ccu"; >> reg = <0x07010000 0x400>; >> -- >> 2.18.0 >> >> -- >> You received this message because you are subscribed to the Google >Groups "linux-sunxi" group. >> To unsubscribe from this group and stop receiving emails from it, >send an email to linux-sunxi+unsubscribe@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout.