* [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition
@ 2012-09-19 3:48 Jim Lin
2012-09-19 6:29 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Jim Lin @ 2012-09-19 3:48 UTC (permalink / raw)
To: gregkh, swarren; +Cc: linux-usb, linux-kernel, Jim Lin
Fix the issue that EHCI registers, hostpc[0] and usbmode_ex,
are not correctly accessed on Tegra3 platform.
Signed-off-by: Jim Lin <jilin@nvidia.com>
---
Changes in v2:
- Modify array size for reserved4[] only.
- Note that defining hostpc[0] is for a variable-length object.
include/linux/usb/ehci_def.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/usb/ehci_def.h b/include/linux/usb/ehci_def.h
index de4b9ed..b3c9d1b 100644
--- a/include/linux/usb/ehci_def.h
+++ b/include/linux/usb/ehci_def.h
@@ -171,7 +171,7 @@ struct ehci_regs {
#define USBMODE_CM_HC (3<<0) /* host controller mode */
#define USBMODE_CM_IDLE (0<<0) /* idle state */
- u32 reserved4[7];
+ u32 reserved4[6];
/* Moorestown has some non-standard registers, partially due to the fact that
* its EHCI controller has both TT and LPM support. HOSTPCx are extensions to
--
1.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition
2012-09-19 3:48 [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition Jim Lin
@ 2012-09-19 6:29 ` Greg KH
2012-09-19 7:53 ` Jim Lin
2012-09-19 8:04 ` Jim Lin
0 siblings, 2 replies; 6+ messages in thread
From: Greg KH @ 2012-09-19 6:29 UTC (permalink / raw)
To: Jim Lin; +Cc: swarren, linux-usb, linux-kernel
On Wed, Sep 19, 2012 at 11:48:50AM +0800, Jim Lin wrote:
> Fix the issue that EHCI registers, hostpc[0] and usbmode_ex,
> are not correctly accessed on Tegra3 platform.
>
> Signed-off-by: Jim Lin <jilin@nvidia.com>
> ---
> Changes in v2:
> - Modify array size for reserved4[] only.
> - Note that defining hostpc[0] is for a variable-length object.
Didn't I already apply V1 of this patch? Can you now send me a fixup
given that the first patch had a problem?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition
2012-09-19 6:29 ` Greg KH
@ 2012-09-19 7:53 ` Jim Lin
2012-09-19 8:04 ` Greg KH
2012-09-19 8:04 ` Jim Lin
1 sibling, 1 reply; 6+ messages in thread
From: Jim Lin @ 2012-09-19 7:53 UTC (permalink / raw)
To: Greg KH; +Cc: swarren, linux-usb, linux-kernel
On Wed, 2012-09-19 at 14:29 +0800, Greg KH wrote:
> On Wed, Sep 19, 2012 at 11:48:50AM +0800, Jim Lin wrote:
> > Fix the issue that EHCI registers, hostpc[0] and usbmode_ex,
> > are not correctly accessed on Tegra3 platform.
> >
> > Signed-off-by: Jim Lin <jilin@nvidia.com>
> > ---
> > Changes in v2:
> > - Modify array size for reserved4[] only.
> > - Note that defining hostpc[0] is for a variable-length object.
>
> Didn't I already apply V1 of this patch? Can you now send me a fixup
> given that the first patch had a problem?
>
> thanks,
>
> greg k-h
If you have applied v1, that's fine.
V2 is just another simplified change, no hurt.
You can ignore it.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition
2012-09-19 7:53 ` Jim Lin
@ 2012-09-19 8:04 ` Greg KH
2012-09-19 8:32 ` Jim Lin
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2012-09-19 8:04 UTC (permalink / raw)
To: Jim Lin; +Cc: swarren, linux-usb, linux-kernel
On Wed, Sep 19, 2012 at 03:53:42PM +0800, Jim Lin wrote:
> On Wed, 2012-09-19 at 14:29 +0800, Greg KH wrote:
> > On Wed, Sep 19, 2012 at 11:48:50AM +0800, Jim Lin wrote:
> > > Fix the issue that EHCI registers, hostpc[0] and usbmode_ex,
> > > are not correctly accessed on Tegra3 platform.
> > >
> > > Signed-off-by: Jim Lin <jilin@nvidia.com>
> > > ---
> > > Changes in v2:
> > > - Modify array size for reserved4[] only.
> > > - Note that defining hostpc[0] is for a variable-length object.
> >
> > Didn't I already apply V1 of this patch? Can you now send me a fixup
> > given that the first patch had a problem?
> >
> > thanks,
> >
> > greg k-h
> If you have applied v1, that's fine.
You should have gotten an email from me saying I applied it, did that
not go through properly?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition
2012-09-19 6:29 ` Greg KH
2012-09-19 7:53 ` Jim Lin
@ 2012-09-19 8:04 ` Jim Lin
1 sibling, 0 replies; 6+ messages in thread
From: Jim Lin @ 2012-09-19 8:04 UTC (permalink / raw)
To: Greg KH; +Cc: swarren, linux-usb, linux-kernel
>-----Original Message-----
>From: Greg KH [mailto:gregkh@linuxfoundation.org]
>Sent: Wednesday, September 19, 2012 2:29 PM
>To: Jim Lin
>Cc: swarren@wwwdotorg.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition
>
>On Wed, Sep 19, 2012 at 11:48:50AM +0800, Jim Lin wrote:
>> Fix the issue that EHCI registers, hostpc[0] and usbmode_ex, are not
>> correctly accessed on Tegra3 platform.
>>
>> Signed-off-by: Jim Lin <jilin@nvidia.com>
>> ---
>> Changes in v2:
>> - Modify array size for reserved4[] only.
>> - Note that defining hostpc[0] is for a variable-length object.
>
>Didn't I already apply V1 of this patch? Can you now send me a fixup given that the first patch had a problem?
>
>thanks,
>
>greg k-h
If you have applied v1, that's fine.
V2 is just another simplified change, no hurt.
You can ignore it.
Thanks.
--
nvpublic
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition
2012-09-19 8:04 ` Greg KH
@ 2012-09-19 8:32 ` Jim Lin
0 siblings, 0 replies; 6+ messages in thread
From: Jim Lin @ 2012-09-19 8:32 UTC (permalink / raw)
To: Greg KH; +Cc: swarren, linux-usb, linux-kernel
>-----Original Message-----
>From: Greg KH [mailto:gregkh@linuxfoundation.org]
>Sent: Wednesday, September 19, 2012 4:04 PM
>To: Jim Lin
>Cc: swarren@wwwdotorg.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition
>
>On Wed, Sep 19, 2012 at 03:53:42PM +0800, Jim Lin wrote:
>> On Wed, 2012-09-19 at 14:29 +0800, Greg KH wrote:
>> > On Wed, Sep 19, 2012 at 11:48:50AM +0800, Jim Lin wrote:
> > > Fix the issue that EHCI registers, hostpc[0] and usbmode_ex, are
>> > > not correctly accessed on Tegra3 platform.
>> > >
>> > > Signed-off-by: Jim Lin <jilin@nvidia.com>
>> > > ---
>> > > Changes in v2:
>> > > - Modify array size for reserved4[] only.
>> > > - Note that defining hostpc[0] is for a variable-length object.
>> >
>> > Didn't I already apply V1 of this patch? Can you now send me a
>> > fixup given that the first patch had a problem?
>> >
>> > thanks,
>> >
>> > greg k-h
>> If you have applied v1, that's fine.
>
>You should have gotten an email from me saying I applied it, did that not go through properly?
>
>thanks,
>
>greg k-h
Sorry, my mistake, I received that mail and thought still having chance to fine tune.
--
nvpublic
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-19 8:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-19 3:48 [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition Jim Lin
2012-09-19 6:29 ` Greg KH
2012-09-19 7:53 ` Jim Lin
2012-09-19 8:04 ` Greg KH
2012-09-19 8:32 ` Jim Lin
2012-09-19 8:04 ` Jim Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).