linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	pjones@redhat.com, open-iscsi@googlegroups.com
Subject: Re: [PATCH 2/2] RFC: iscsi ibft: convert iscsi_ibft module to iscsi boot lib
Date: Mon, 12 Apr 2010 21:32:33 -0500	[thread overview]
Message-ID: <4BC3D7C1.90307@cs.wisc.edu> (raw)
In-Reply-To: <201004122221.05326.konrad@darnok.org>

On 04/12/2010 09:21 PM, Konrad Rzeszutek Wilk wrote:
>> + * Helper routiners to check to determine if the entry is valid
>> + * in the proper iBFT structure.
>> + */
>> +static mode_t ibft_check_nic_for(void *data, int type)
>> +{
>> +	struct ibft_kobject *entry = data;
>> +	struct ibft_nic *nic = entry->nic;
>> +	mode_t rc = 0;
>> +
>> +	switch (type) {
>> +	case ISCSI_BOOT_ETH_INDEX:
>> +	case ISCSI_BOOT_ETH_FLAGS:
>> +		rc = 1;
>
> Did you mean for that value?
>> +		break;
>> +	case ISCSI_BOOT_ETH_IP_ADDR:
>> +		if (memcmp(nic->ip_addr, nulls, sizeof(nic->ip_addr)))
>> +			rc = S_IRUGO;
>> +		break;
>> +	case ISCSI_BOOT_ETH_SUBNET_MASK:
>> +		if (nic->subnet_mask_prefix)
>> +			rc = S_IRUGO;
>> +		break;
>> +	case ISCSI_BOOT_ETH_ORIGIN:
>> +		rc = 1;
>
> and this one as well?

I did not. They should be S_IRUGO. Do you want me to resubmit the 
patches or are you just going to edit those two lines if you merge them?

  reply	other threads:[~2010-04-13  2:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-12 18:06 [PATCH 1/2] RFC: iscsi ibft: separate ibft parsing from sysfs interface michaelc
2010-04-12 18:06 ` [PATCH 2/2] RFC: iscsi ibft: convert iscsi_ibft module to iscsi boot lib michaelc
2010-04-13  2:21   ` Konrad Rzeszutek Wilk
2010-04-13  2:32     ` Mike Christie [this message]
2010-04-13  2:36       ` Konrad Rzeszutek Wilk
2010-04-13 14:59         ` Peter Jones
2010-04-13  2:20 ` [PATCH 1/2] RFC: iscsi ibft: separate ibft parsing from sysfs interface Konrad Rzeszutek Wilk
2010-08-11 15:54   ` Randy Dunlap
2010-08-11 16:04     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BC3D7C1.90307@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=konrad@darnok.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=open-iscsi@googlegroups.com \
    --cc=pjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).