From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751034AbaGZINW (ORCPT ); Sat, 26 Jul 2014 04:13:22 -0400 Received: from elanic.emc.com.tw ([192.72.220.188]:43680 "EHLO elanic.emc.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbaGZINP convert rfc822-to-8bit (ORCPT ); Sat, 26 Jul 2014 04:13:15 -0400 Content-Type: text/plain; charset=big5 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH v2] Input: add i2c/smbus driver for elan touchpad From: cheng wei Lin In-Reply-To: <20140725200656.GA2827@core.coreip.homeip.net> Date: Sat, 26 Jul 2014 16:12:58 +0800 Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, bleung@chromium.org, agnescheng@chromium.org, =?big5?B?IlNSRDEgJiM2NTUzMzvntr3uJiM2NTUzMzsmIzY1NTMzOz+zoyYj?= =?big5?B?NjU1MzM7JiM2NTUzMzsmIzY1NTMzOyYjNjU1MzM7Ig==?= , jeff.chuang@emc.com.tw Content-Transfer-Encoding: 8BIT Message-Id: <4BE637D2-E28B-4344-B77A-6260566F7CF6@emc.com.tw> References: <1389064083-11018-1-git-send-email-dusonlin@emc.com.tw> <20140724180516.GA26752@core.coreip.homeip.net> <73E9FA09-55D6-409D-A902-29CC3F414CBF@emc.com.tw> <20140725182053.GA23356@core.coreip.homeip.net> <20140725200656.GA2827@core.coreip.homeip.net> To: Dmitry Torokhov X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, Yes, we intend to do this. Could you help to keep the original code, thank you. Duson Dmitry Torokhov ©ó 2014/7/26 ¤W¤È4:06 ¼g¹D¡G > On Fri, Jul 25, 2014 at 11:20:53AM -0700, Dmitry Torokhov wrote: >> Hi Duson, >> >> On Sat, Jul 26, 2014 at 02:05:02AM +0800, cheng wei Lin wrote: >>> Hi Dmitry, >>> >>> Sorry for late to reply you and thanks for your command >>> >>> Yes, I also agree, it looks great than my original code. >> >> Thank you for confirming. >> >>> So, should I modify this and upstream v3 patch for you? >> >> No, that is fine, I'll fix it up on my end. > > Hmm, I am also looking at elan_get_x_resolution() and in case of SMB > we'll never get negative result since we are doing > "elan_convert_res(val[1] & 0x0F)". Was it intended as such, or do we > need to extend sign here via > > (((char)(val[1] & 0x0F)) << 4) >> 4; > > Thanks. > > -- > Dmitry >