From: Edward Shishkin <edward.shishkin@gmail.com>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, clemens@ladisch.de,
debora@linux.vnet.ibm.com, dri-devel@lists.freedesktop.org,
linux-i2c@vger.kernel.org, linux1394-devel@lists.sourceforge.net,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.
Date: Mon, 14 Jun 2010 23:05:46 +0200 [thread overview]
Message-ID: <4C1699AA.3000900@gmail.com> (raw)
In-Reply-To: <1276547208-26569-2-git-send-email-justinmattock@gmail.com>
Justin P. Mattock wrote:
> Not sure if this is correct or not.
> the below patch gets rid of this warning message
> produced by gcc 4.6.0
>
> fs/reiserfs/stree.c: In function 'search_by_key':
> fs/reiserfs/stree.c:602:6: warning: variable 'right_neighbor_of_leaf_node' set but not used
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>
Acked-by: Edward Shishkin <edward.shishkin@gmail.com>
> ---
> fs/reiserfs/stree.c | 7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c
> index 313d39d..73086ad 100644
> --- a/fs/reiserfs/stree.c
> +++ b/fs/reiserfs/stree.c
> @@ -599,7 +599,6 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s
> struct buffer_head *bh;
> struct path_element *last_element;
> int node_level, retval;
> - int right_neighbor_of_leaf_node;
> int fs_gen;
> struct buffer_head *reada_bh[SEARCH_BY_KEY_READA];
> b_blocknr_t reada_blocks[SEARCH_BY_KEY_READA];
> @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s
>
> pathrelse(search_path);
>
> - right_neighbor_of_leaf_node = 0;
> -
> +
> /* With each iteration of this loop we search through the items in the
> current node, and calculate the next current node(next path element)
> for the next iteration of this loop.. */
> @@ -695,8 +693,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s
> starting from the root. */
> block_number = SB_ROOT_BLOCK(sb);
> expected_level = -1;
> - right_neighbor_of_leaf_node = 0;
> -
> +
> /* repeat search from the root */
> continue;
> }
>
next prev parent reply other threads:[~2010-06-14 21:06 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 20:26 [PATCH 0/8] Fix gcc 4.6.0 set but not used warning messages Justin P. Mattock
2010-06-14 20:26 ` [PATCH 1/8]reiserfs:stree.c Fix variable set but not used Justin P. Mattock
2010-06-14 20:48 ` Nick Bowler
2010-06-14 21:09 ` Justin P. Mattock
2010-06-14 21:05 ` Edward Shishkin [this message]
2010-06-14 21:21 ` Justin P. Mattock
2010-06-14 21:47 ` Edward Shishkin
2010-06-14 22:50 ` Justin P. Mattock
2010-06-14 23:07 ` Stefan Richter
2010-06-15 0:01 ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 2/8]bluetooth/hci_ldisc.c Fix warning: variable 'tty' " Justin P. Mattock
2010-06-15 0:24 ` Gustavo F. Padovan
2010-06-14 20:26 ` [PATCH 3/8]char/hpet.c Fix variable 'hpet' " Justin P. Mattock
2010-06-14 20:26 ` [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' " Justin P. Mattock
2010-06-15 0:13 ` Valdis.Kletnieks
2010-06-15 2:12 ` Justin P. Mattock
2010-06-15 3:49 ` Valdis.Kletnieks
2010-06-15 3:56 ` Justin P. Mattock
2010-06-15 5:29 ` Peter Stuge
2010-06-15 5:58 ` Justin P. Mattock
2010-06-15 6:57 ` Stefan Richter
2010-06-15 7:27 ` Justin P. Mattock
2010-06-15 7:56 ` Stefan Richter
2010-06-15 8:30 ` Justin P. Mattock
2010-06-15 9:19 ` Jean Delvare
2010-06-15 9:41 ` Justin P. Mattock
2010-06-15 18:53 ` Sergey V.
2010-06-15 19:36 ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 5/8]drm:drm_gem Fix warning: variable 'dev' " Justin P. Mattock
2010-06-14 20:26 ` [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' " Justin P. Mattock
2010-06-14 20:53 ` Jean Delvare
2010-06-14 21:06 ` Justin P. Mattock
2010-06-15 11:43 ` Jean Delvare
2010-06-15 16:51 ` Justin P. Mattock
2010-06-14 21:28 ` David Daney
2010-06-15 11:40 ` Jean Delvare
2010-06-15 16:20 ` David Daney
2010-06-16 9:45 ` Jean Delvare
2010-06-14 20:26 ` [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' " Justin P. Mattock
2010-06-14 21:44 ` [PATCH] ieee1394: sbp2: remove unused code Stefan Richter
2010-06-14 22:35 ` Justin P. Mattock
2010-06-14 23:22 ` Stefan Richter
2010-06-14 23:58 ` Justin P. Mattock
2010-06-15 0:08 ` (no subject) Stefan Richter
2010-06-15 0:00 ` [PATCH] ieee1394: remove unused variables Stefan Richter
2010-06-15 0:05 ` [PATCH] ieee1394: sbp2: remove unused code Stefan Richter
2010-06-15 1:59 ` Justin P. Mattock
2010-06-15 11:38 ` [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used Jean Delvare
2010-06-15 16:52 ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 8/8]tuners:tuner-simple Fix warning: variable 'tun' " Justin P. Mattock
2010-06-15 5:16 ` Mauro Carvalho Chehab
2010-06-15 5:37 ` Justin P. Mattock
2010-06-15 5:50 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1699AA.3000900@gmail.com \
--to=edward.shishkin@gmail.com \
--cc=clemens@ladisch.de \
--cc=debora@linux.vnet.ibm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=justinmattock@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).