From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756234Ab0FOAAz (ORCPT ); Mon, 14 Jun 2010 20:00:55 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:56713 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752856Ab0FOAAw (ORCPT ); Mon, 14 Jun 2010 20:00:52 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=peu3zb+GT3Km32p5ZQbVIDGIYD5ff+jYFX1vrMdkeXIM0Vav1yASqKiY5/7NIPio62 l9Bdv1DSG7wluwthV3Z8FR3KTY0CYB5NnEaWYU6bkHvijTA9WLBYNTKw+Twe+b4KE880 4tLAV89Bp3e0Ha+zncUbl/a4dXhyEKBSJHCls= Message-ID: <4C16C2C2.6000503@gmail.com> Date: Mon, 14 Jun 2010 17:01:06 -0700 From: "Justin P. Mattock" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091114 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: Stefan Richter CC: Edward Shishkin , linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-bluetooth@vger.kernel.org, clemens@ladisch.de, debora@linux.vnet.ibm.com, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-media@vger.kernel.org Subject: Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used. References: <1276547208-26569-1-git-send-email-justinmattock@gmail.com> <1276547208-26569-2-git-send-email-justinmattock@gmail.com> <4C1699AA.3000900@gmail.com> <4C169D71.90800@gmail.com> <4C16A372.6020604@gmail.com> <4C16B236.7080506@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/14/2010 04:07 PM, Stefan Richter wrote: > On 14 Jun, Justin P. Mattock wrote: >> On 06/14/2010 02:47 PM, Edward Shishkin wrote: >>> Whitespaces should be removed. >>> I recommend quilt package for managing patches: >>> "quilt refresh --strip-trailing-whitespace" is your friend.. >> >> o.k. I resent this.. fixed the whitespace(hopefully) >> and add your Acked to it. >> as for quilt I'll have to look into that.. >> (using a lfs system, so if the sourcecode is easy >> to deal with(build), then it's a good but if it becomes >> a nightmare maybe not!!). > > Since you appear to generate the patches with git, you can use "git diff > --check [...]" for some basic whitespace checks (additions of trailing > space, additions of space before tab). For more extensive checks, try > "git diff [...] | scripts/checkpatch.pl -". Check this before you > commit. If you committed already, "git commit --amend [-a] [...]" lets > you alter the very last commit of course. Thanks for the info on this, copied it down in my book of commands... Justin P. Mattock