linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: ngupta@vflare.org
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	devel@driverdev.osuosl.org, linux-next@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	gregkh@suse.de
Subject: Re: [PATCH -next] zram: fix build errors, depends on BLOCK
Date: Thu, 24 Jun 2010 08:53:25 -0700	[thread overview]
Message-ID: <4C237F75.70603@oracle.com> (raw)
In-Reply-To: <4C237E12.9020903@vflare.org>

On 06/24/10 08:47, Nitin Gupta wrote:
> On 06/24/2010 08:02 PM, Randy Dunlap wrote:
>> On 06/23/10 21:36, Nitin Gupta wrote:
>>> On 06/24/2010 08:57 AM, Randy Dunlap wrote:
>>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>>
>>>> Fix 49 zram build errors in one swoop.  Examples:
>>>>
>>>> drivers/staging/zram/zram_drv.c:225: error: dereferencing pointer to incomplete type
>>>> drivers/staging/zram/zram_drv.c:226: error: implicit declaration of function 'bio_for_each_segment'
>>>> drivers/staging/zram/zram_drv.c:226: error: expected ';' before '{' token
>>>> drivers/staging/zram/zram_drv.c:281: error: implicit declaration of function 'bio_endio'
>>>> drivers/staging/zram/zram_drv.c:285: error: implicit declaration of function 'bio_io_error'
>>>> drivers/staging/zram/zram_drv.c:545: error: implicit declaration of function 'set_capacity'
>>>> drivers/staging/zram/zram_drv.c:548: error: implicit declaration of function 'queue_flag_set_unlocked'
>>>> drivers/staging/zram/zram_drv.c:548: error: 'QUEUE_FLAG_NONROT' undeclared (first use in this function)
>>>> drivers/staging/zram/zram_drv.c:548: error: dereferencing pointer to incomplete type
>>>>
>>>
>>>
>>> Thanks for the fix. Strangely, I didn't get any of these
>>> errors when I compiled against mainline.
>>
>> This patch isn't against mainline, it's against linux-next.
>> See subject's "[PATCH -next]" hint.
>>
> 
> Randy, I understood that your patch is against linux-next. I was just wondering
> why the error did not come up when I applied and tested this whole zram thing
> against linux mainline.

Did you test a build with CONFIG_BLOCK disabled?

> Anyways, thanks for the fix.


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2010-06-24 15:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-23  5:45 linux-next: Tree for June 23 Stephen Rothwell
2010-06-24  3:27 ` [PATCH -next] zram: fix build errors, depends on BLOCK Randy Dunlap
2010-06-24  4:36   ` Nitin Gupta
2010-06-24 14:32     ` Randy Dunlap
2010-06-24 15:47       ` Nitin Gupta
2010-06-24 15:53         ` Randy Dunlap [this message]
2010-06-24 16:07           ` Nitin Gupta
2010-06-24  3:28 ` [PATCH -next] staging: fix wlan-ng depends Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C237F75.70603@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=ngupta@vflare.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).