From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755996Ab0FXQG4 (ORCPT ); Thu, 24 Jun 2010 12:06:56 -0400 Received: from mail-px0-f174.google.com ([209.85.212.174]:39874 "EHLO mail-px0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754299Ab0FXQGy (ORCPT ); Thu, 24 Jun 2010 12:06:54 -0400 Message-ID: <4C2382AF.2030807@vflare.org> Date: Thu, 24 Jun 2010 21:37:11 +0530 From: Nitin Gupta Reply-To: ngupta@vflare.org User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5 MIME-Version: 1.0 To: Randy Dunlap CC: Stephen Rothwell , devel@driverdev.osuosl.org, linux-next@vger.kernel.org, LKML , gregkh@suse.de Subject: Re: [PATCH -next] zram: fix build errors, depends on BLOCK References: <20100623154531.0a4b02e1.sfr@canb.auug.org.au> <20100623202709.4ecb798c.randy.dunlap@oracle.com> <4C22E0B3.60203@vflare.org> <4C236C93.1020407@oracle.com> <4C237E12.9020903@vflare.org> <4C237F75.70603@oracle.com> In-Reply-To: <4C237F75.70603@oracle.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/24/2010 09:23 PM, Randy Dunlap wrote: > On 06/24/10 08:47, Nitin Gupta wrote: >> On 06/24/2010 08:02 PM, Randy Dunlap wrote: >>> On 06/23/10 21:36, Nitin Gupta wrote: >>>> On 06/24/2010 08:57 AM, Randy Dunlap wrote: >>>>> From: Randy Dunlap >>>>> >>>>> Fix 49 zram build errors in one swoop. Examples: >>>>> >>>>> drivers/staging/zram/zram_drv.c:225: error: dereferencing pointer to incomplete type >>>>> drivers/staging/zram/zram_drv.c:226: error: implicit declaration of function 'bio_for_each_segment' >>>>> drivers/staging/zram/zram_drv.c:226: error: expected ';' before '{' token >>>>> drivers/staging/zram/zram_drv.c:281: error: implicit declaration of function 'bio_endio' >>>>> drivers/staging/zram/zram_drv.c:285: error: implicit declaration of function 'bio_io_error' >>>>> drivers/staging/zram/zram_drv.c:545: error: implicit declaration of function 'set_capacity' >>>>> drivers/staging/zram/zram_drv.c:548: error: implicit declaration of function 'queue_flag_set_unlocked' >>>>> drivers/staging/zram/zram_drv.c:548: error: 'QUEUE_FLAG_NONROT' undeclared (first use in this function) >>>>> drivers/staging/zram/zram_drv.c:548: error: dereferencing pointer to incomplete type >>>>> >>>> >>>> >>>> Thanks for the fix. Strangely, I didn't get any of these >>>> errors when I compiled against mainline. >>> >>> This patch isn't against mainline, it's against linux-next. >>> See subject's "[PATCH -next]" hint. >>> >> >> Randy, I understood that your patch is against linux-next. I was just wondering >> why the error did not come up when I applied and tested this whole zram thing >> against linux mainline. > > Did you test a build with CONFIG_BLOCK disabled? > Ah, now I got it. No, I didn't test with CONFIG_BLOCK disabled. Thanks, Nitin