From: Jeff Garzik <jgarzik@pobox.com>
To: Wolfgang Denk <wd@denx.de>
Cc: Rupjyoti Sarmah <rsarmah@apm.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
sr@denx.de, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v1]460EX on-chip SATA driver<resubmisison>
Date: Wed, 30 Jun 2010 15:17:05 -0400 [thread overview]
Message-ID: <4C2B9831.9020801@pobox.com> (raw)
In-Reply-To: <20100630184728.C02D014EBF9@gemini.denx.de>
On 06/30/2010 02:47 PM, Wolfgang Denk wrote:
> Dear Rupjyoti Sarmah,
>
> In message<3b928476b2fffdcf0694e5436e8a482f@mail.gmail.com> you wrote:
>>
>> I took the mainline kernel v2.6.35-rc3 and downloaded using the git
>> download link.
>> I created the patch on 6/24/2010 after doing a git pull.
>
> I don;t think that you used v2.6.35-rc3; using this version, I still
> get this:
>
> drivers/ata/sata_dwc_460ex.c:43:1: warning: "DRV_NAME" redefined
> In file included from drivers/ata/sata_dwc_460ex.c:38:
> drivers/ata/libata.h:31:1: warning: this is the location of the previous definition
> drivers/ata/sata_dwc_460ex.c:44:1: warning: "DRV_VERSION" redefined
> drivers/ata/libata.h:32:1: warning: this is the location of the previous definition
> drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_scr_read':
> drivers/ata/sata_dwc_460ex.c:777: error: 'struct ata_port' has no member named 'ioaddr'
> drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_scr_write':
> drivers/ata/sata_dwc_460ex.c:793: error: 'struct ata_port' has no member named 'ioaddr'
> drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_error_intr':
> drivers/ata/sata_dwc_460ex.c:844: error: 'struct ata_port_operations' has no member named 'sff_check_status'
It looks like -your- build config is missing CONFIG_ATA_SFF or similar.
If you actually look at include/linux/libata.h, you see that struct
ata_port_operations most definitely has a member named sff_check_status,
for example. Ditto ata_port and member ioaddr, etc.
Jeff
next prev parent reply other threads:[~2010-06-30 19:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 13:27 [PATCH v1]460EX on-chip SATA driver<resubmisison> Rupjyoti Sarmah
2010-06-30 11:58 ` Wolfgang Denk
2010-06-30 12:44 ` Rupjyoti Sarmah
2010-06-30 18:23 ` Wolfgang Denk
2010-06-30 18:47 ` Wolfgang Denk
2010-06-30 19:17 ` Jeff Garzik [this message]
2010-06-30 20:03 ` Josh Boyer
2010-06-30 22:55 ` Wolfgang Denk
2010-07-01 17:44 ` Rupjyoti Sarmah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2B9831.9020801@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rsarmah@apm.com \
--cc=sr@denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).