From: "Michael Duane" <Mike.Duane@digeo.com>
To: "Brad Hards" <bhards@bigpond.net.au>, <linux-kernel@vger.kernel.org>
Subject: RE: CDCether.c
Date: Tue, 24 Sep 2002 14:30:21 -0700 [thread overview]
Message-ID: <4C568C6A13479744AA1EA3E97EEEB3231B7DEF@schumi.digeo.com> (raw)
Think I found the problem. The following patch is generated on the
2.5.36 code base. Seems that the ^ will only work where skb->len
is <= ether_dev->data_ep_out_size. (ether_dev->data_ep_out_size is
64 on my modem).
Mike
--- linux-2.5.36/drivers/usb/net/cdc-ether.c Tue Sep 17 17:58:43 2002
+++ patched/drivers/usb/net/cdc-ether.c Tue Sep 24 14:24:55 2002
@@ -276,7 +276,7 @@
// into an integer number of USB packets, we force it to send one
// more byte so the device will get a runt USB packet signalling the
// end of the ethernet frame
- if ( (skb->len) ^ (ether_dev->data_ep_out_size) ) {
+ if ( (skb->len) % (ether_dev->data_ep_out_size) ) {
// It was not an exact multiple
// no need to add anything extra
count = skb->len;
> -----Original Message-----
> From: Brad Hards [mailto:bhards@bigpond.net.au]
> Sent: Thursday, September 19, 2002 2:12 PM
> To: Michael Duane; linux-kernel@vger.kernel.org
> Subject: Re: CDCether.c
>
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Fri, 20 Sep 2002 01:22, Michael Duane wrote:
> > No, this is quite different. It appears to be a function of packet
> > size. ping -s <size> <host> will generate packet loss up to 100
> > percent with any size of (86+(64*n)). All other values work fine.
> > tcpdump on the linux side sees multiple packet retries with
> > correct back-off timeing, but the network side never sees the
> > packet. Now for the odd part - any network activity on another
> > session to the same box will free the "wedged" packet and the
> > network will recieve the last packet sent in the linux retry
> > sequence.
> Ahh, maybe a missing zero length packet problem. I'll take
> another look.
>
> Brad
>
>
> - --
> http://conf.linux.org.au. 22-25Jan2003. Perth, Australia.
> Birds in Black.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.6 (GNU/Linux)
> Comment: For info see http://www.gnupg.org
>
> iD8DBQE9ij2RW6pHgIdAuOMRAmgqAJwPPipMhYxO2QQ0L1VB6yXJtbX8GQCdGpvw
> mWRRiqjOTJUmYWsXLyghSgo=
> =LRBZ
> -----END PGP SIGNATURE-----
>
>
next reply other threads:[~2002-09-24 21:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-24 21:30 Michael Duane [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-09-19 17:09 CDCether.c Michael Duane
2002-09-19 15:22 CDCether.c Michael Duane
2002-09-19 21:11 ` CDCether.c Brad Hards
2002-09-18 23:49 CDCether.c Michael Duane
2002-09-19 0:15 ` CDCether.c Greg KH
2002-09-19 6:20 ` CDCether.c Brad Hards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C568C6A13479744AA1EA3E97EEEB3231B7DEF@schumi.digeo.com \
--to=mike.duane@digeo.com \
--cc=bhards@bigpond.net.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).