From: Chen Gong <gong.chen@linux.intel.com>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"JBeulich@novell.com" <JBeulich@novell.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [1/2] hwmon: uniform the init style of pkgtemp
Date: Fri, 08 Oct 2010 13:25:01 +0800 [thread overview]
Message-ID: <4CAEAB2D.1070501@linux.intel.com> (raw)
In-Reply-To: <20101008035248.GA23368@ericsson.com>
于 10/8/2010 11:52 AM, Guenter Roeck 写道:
> On Thu, Oct 07, 2010 at 11:42:05PM -0400, Chen Gong wrote:
>> 于 10/2/2010 11:26 AM, Guenter Roeck 写道:
>>> On Sun, Sep 26, 2010 at 05:59:59AM -0000, Chen Gong wrote:
>>>> pkgtemp is derived from coretemp, so some reasonable
>>>> logics should be applied onto pkgtemp, too. Such as
>>>> the init logic here.
>>>>
>>>> Signed-off-by: Chen Gong<gong.chen@linux.intel.com>
>>>> Acked-by: Jan Beulich<jbeulich@novell.com>
>>>>
>>> Hi,
>>>
>>> this patch, when applied with CONFIG_HOTPLUG_CPU undefined, causes a compile failure
>>> because it tries to access pkgtemp_cpu_notifier which is not defined in this case.
>>>
>>> For that reason, I have removed the patch from the list of applied patches for -next.
>>> Please re-submit a version which compiles for all combinations of HOTPLUG_CPU and SMP
>>> defined/undefined.
>>>
>>> Thanks,
>>> Guenter
>>>
>> Sorry for late. I just come back from my holiday. If only this one patch
>> is applied, it is broken, but it will be OK after these 2 patches are
>> applied. I tested the patches when CONFIG_SMP is undefined, it does be
>
> Each patch by itself must be compilable, otherwise we break the ability
> to bisect. Not a good idea.
Yes, but in fact it is an existing issue, not new incoming. The 1st
patch isn't used for this purpose.
>
>> broken again. My suggestion is adding a macro definiton in the pkgtemp.c
>> like "#include<asm/smp.h>". If it is doable, I will re-post a new patch
>> series
>
> I assume you mean to add the include directive. Yes, that should do it,
> but please make sure that it compiles.
Sure, of course
>
> Thanks,
> Guenter
>
next prev parent reply other threads:[~2010-10-08 5:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-26 5:59 [PATHC 0/2] update and cleanup patches for coretemp etc Chen Gong
2010-09-26 5:59 ` [PATCH 1/2] hwmon: uniform the init style of pkgtemp Chen Gong
2010-09-27 7:10 ` Jan Beulich
2010-09-27 14:52 ` [lm-sensors] " Guenter Roeck
2010-10-02 3:26 ` [1/2] " Guenter Roeck
2010-10-08 3:42 ` Chen Gong
2010-10-08 3:52 ` Guenter Roeck
2010-10-08 5:25 ` Chen Gong [this message]
2010-09-26 6:00 ` [PATCH 2/2] hwmon: cleanup some hotplug related macro definition Chen Gong
2010-09-27 7:11 ` Jan Beulich
2010-09-27 14:58 ` [2/2] " Guenter Roeck
2010-10-02 3:28 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAEAB2D.1070501@linux.intel.com \
--to=gong.chen@linux.intel.com \
--cc=JBeulich@novell.com \
--cc=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).