From: Jens Axboe <jaxboe@fusionio.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"linux-m68k@vger.kernel.org" <linux-m68k@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH] fix amiga and atari floppy driver compile warning
Date: Mon, 15 Nov 2010 19:33:21 +0100 [thread overview]
Message-ID: <4CE17CF1.3010009@fusionio.com> (raw)
In-Reply-To: <20101115152709.GF30792@redhat.com>
On 2010-11-15 16:27, Vivek Goyal wrote:
> On Thu, Oct 28, 2010 at 02:42:23PM -0400, Vivek Goyal wrote:
>> Geert, my crosstool don't produce warning below. I guess this has to do
>> something with compiler version.
>>
>> - Geert noticed following warning during compilation.
>>
>> drivers/block/amiflop.c:1344: warning: ‘rq’ may be used uninitialized in
>> this function
>> drivers/block/ataflop.c:1402: warning: ‘rq’ may be used uninitialized in
>> this function
>>
>> - Initialize rq to NULL to fix the warning. If we can't find a suitable request
>> to dispatch, this function should return NULL instead of a possibly garbage
>> pointer.
>>
>> - Cross compile tested only. Don't have hardware to test it.
>>
>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
>
> Hi Jens,
>
> Do you have any concerns about this patch? If not, can you please apply
> it.
No, it's straight forward just got missed in travel. Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2010-11-15 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 18:42 [PATCH] fix amiga and atari floppy driver compile warning Vivek Goyal
2010-10-28 18:46 ` Geert Uytterhoeven
2010-11-15 15:27 ` Vivek Goyal
2010-11-15 18:33 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE17CF1.3010009@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).