From: "Jan Beulich" <JBeulich@novell.com>
To: <mingo@elte.hu>, <heukelum@fastmail.fm>,
"Tetsuo Handa" <penguin-kernel@I-love.SAKURA.ne.jp>,
<hpa@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.37-rc2] x86, asm: Add parentheses around one pushl_cfi argument
Date: Tue, 16 Nov 2010 07:39:38 +0000 [thread overview]
Message-ID: <4CE2434A02000078000226C7@vpn.id2.novell.com> (raw)
In-Reply-To: <201011160445.oAG4jGif079860@www262.sakura.ne.jp>
>>> On 16.11.10 at 05:45, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> From ed935c12f0b2b09c1586d22925261378e0d7eb83 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Tue, 16 Nov 2010 13:33:07 +0900
> Subject: [PATCH] x86, asm: Add parentheses around one pushl_cfi argument
>
> Commit df5d1874 "x86: Use {push,pop}{l,q}_cfi in more places" caused GNU
> assembler 2.15 (Debian Sarge) to fail. It is still failing as of commit
> 07bd8516 "x86, asm: Restore parentheses around one pushl_cfi argument".
> This patch solves build failure with GNU assembler 2.15.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Jan Beulich <jbeulich@novell.com>
> ---
> arch/x86/kernel/entry_32.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
> index 59e175e..591e601 100644
> --- a/arch/x86/kernel/entry_32.S
> +++ b/arch/x86/kernel/entry_32.S
> @@ -395,7 +395,7 @@ sysenter_past_esp:
> * A tiny bit of offset fixup is necessary - 4*4 means the 4 words
> * pushed above; +8 corresponds to copy_thread's esp0 setting.
> */
> - pushl_cfi (TI_sysenter_return-THREAD_SIZE_asm+8+4*4)(%esp)
> + pushl_cfi ((TI_sysenter_return)-THREAD_SIZE_asm+8+4*4)(%esp)
> CFI_REL_OFFSET eip, 0
>
> pushl_cfi %eax
next prev parent reply other threads:[~2010-11-16 7:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 4:45 [PATCH 2.6.37-rc2] x86, asm: Add parentheses around one pushl_cfi argument Tetsuo Handa
2010-11-16 7:39 ` Jan Beulich [this message]
2010-11-18 14:06 ` [tip:x86/urgent] x86, asm: Fix binutils 2.15 build failure tip-bot for Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE2434A02000078000226C7@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=heukelum@fastmail.fm \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).