From: "Patil, Rachna" <rachna@ti.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: Russell King <linux@arm.linux.org.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Dmitry Torokhov <dtor@mail.ru>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <rob.herring@calxeda.com>,
"Hebbar, Gururaja" <gururaja.hebbar@ti.com>,
Jonathan Cameron <jic23@cam.ac.uk>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v4 5/8] MFD: ti_am335x_tscadc: Add DT support
Date: Wed, 6 Feb 2013 11:17:23 +0000 [thread overview]
Message-ID: <4CE347531D4CA947960AF71FF095B9323E9B44E9@DBDE01.ent.ti.com> (raw)
In-Reply-To: 79CD15C6BA57404B839C016229A409A83EBEFAE8@DBDE01.ent.ti.com
Hi Koen,
> <SNIP>
> > > > Since AM335x is DT only, why is there a platform data codepath and why is it the first branch it tries? And I guess the next question is related to the first: why doesn't it work when used with DT? When I copy over the nodes from the evm.dts to my board I get "tsc tsc: Missing platform data" in dmesg.
> > >
> > > This IP came up 1st on AM335x, but it is not platform dependent. The driver can be used on other platforms where-in DT is not supported.
> > > According to the maintainers platform data takes precedence over DT. Hence the order.
> > >
> >
> > Rachana,
> >
> > I see no point adding support for platform_data when you know that none of older platforms are going to use this driver and all future platforms _must_ follow device-tree model.
> >
> > So I agree that you should remove board file dependency from the driver.
>
> Ok. I will remove support for platform data in the next version of patches.
>
> >
> >
> > > I do not see "Missing platform data" error msg in the latest driver. I am not able to trace from where this got populated.
> > >
> >
> > Can you share the branch which you have tested?
>
> https://github.com/patilrachna/linux/tree/v3.8_rc3_MFD_TSCADC_DT-v2
Did you get a chance to test this branch?
And can you also share your branch, on which you observed the issue.
Regards,
Rachna
next prev parent reply other threads:[~2013-02-06 11:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 3:45 [PATCH v4 0/8] MFD: ti_am335x_tscadc: DT support and TSC features addition Patil, Rachna
2013-01-24 3:45 ` [PATCH v4 1/8] input: ti_am335x_tsc: Step enable bits made configurable Patil, Rachna
2013-01-24 3:45 ` [PATCH v4 2/8] input: ti_am335x_tsc: Order of TSC wires, " Patil, Rachna
2013-01-24 3:45 ` [PATCH v4 3/8] input: touchscreen: ti_tsc: remove unwanted fifo flush Patil, Rachna
2013-01-24 3:45 ` [PATCH v4 4/8] MFD: ti_am335x_tscadc: add device tree binding information Patil, Rachna
2013-01-27 14:11 ` Peter Korsgaard
2013-01-24 3:45 ` [PATCH v4 5/8] MFD: ti_am335x_tscadc: Add DT support Patil, Rachna
2013-01-30 10:40 ` Koen Kooi
2013-01-31 4:11 ` Patil, Rachna
2013-01-31 5:02 ` Hiremath, Vaibhav
2013-01-31 12:25 ` Patil, Rachna
2013-02-06 11:17 ` Patil, Rachna [this message]
2013-01-24 3:45 ` [PATCH v4 6/8] input: ti_am335x_tsc: " Patil, Rachna
2013-01-24 3:45 ` [PATCH v4 7/8] IIO: ti_am335x_adc: " Patil, Rachna
2013-01-24 3:45 ` [PATCH v4 8/8] arm/dts: AM335x-evm: Add TSC/ADC MFD device support Patil, Rachna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE347531D4CA947960AF71FF095B9323E9B44E9@DBDE01.ent.ti.com \
--to=rachna@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@mail.ru \
--cc=gururaja.hebbar@ti.com \
--cc=jic23@cam.ac.uk \
--cc=koen@dominion.thruhere.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).