From: "Jan Beulich" <JBeulich@novell.com>
To: "Yinghai Lu" <yinghai@kernel.org>
Cc: <mingo@elte.hu>, <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>, <hpa@zytor.com>
Subject: Re: [PATCH, v2] x86-64: fix and clean up AMD Fam10 MMCONF enabling
Date: Wed, 17 Nov 2010 07:52:15 +0000 [thread overview]
Message-ID: <4CE397BF0200007800022AD6@vpn.id2.novell.com> (raw)
In-Reply-To: <4CE30524.5080802@kernel.org>
>>> On 16.11.10 at 23:26, Yinghai Lu <yinghai@kernel.org> wrote:
> On 11/16/2010 12:25 AM, Jan Beulich wrote:
>> @@ -206,8 +200,10 @@ void __cpuinit fam10h_check_enable_mmcfg
>> * with 256 buses
>> */
>> get_fam10h_pci_mmconf_base();
>> - if (fam10h_pci_mmconf_base_status <= 0)
>> + if (!fam10h_pci_mmconf_base) {
>> + pci_probe &= ~PCI_CHECK_ENABLE_AMD_MMCONF;
>
> case: if no cpu mmconf reg are set by BIOS and later if BSP can not get new
> base,
>
> this pci_probe &= line will be called for every AP...
No, because the function itself has
if (!(pci_probe & PCI_CHECK_ENABLE_AMD_MMCONF))
return;
at its very beginning.
Jan
next prev parent reply other threads:[~2010-11-17 7:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 8:25 [PATCH, v2] x86-64: fix and clean up AMD Fam10 MMCONF enabling Jan Beulich
2010-11-16 22:26 ` Yinghai Lu
2010-11-17 7:52 ` Jan Beulich [this message]
2010-11-17 9:18 ` Yinghai Lu
2010-11-18 14:14 ` [tip:x86/urgent] x86-64: Fix " tip-bot for Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE397BF0200007800022AD6@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).