From: Randy Dunlap <randy.dunlap@oracle.com>
To: Zhang Rui <rui.zhang@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] acpi: fix acpi/video.h error and warning when PM is not enabled
Date: Wed, 17 Nov 2010 08:06:24 -0800 [thread overview]
Message-ID: <4CE3FD80.7010808@oracle.com> (raw)
In-Reply-To: <1289957348.8148.2098.camel@rui>
On 11/16/10 17:29, Zhang Rui wrote:
> On Wed, 2010-11-17 at 08:59 +0800, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> When CONFIG_PM is not enabled, acpi/video.h causes a build error.
>> Also fix a longstanding warning.
>>
>> include/acpi/video.h:22: warning: 'struct acpi_device' declared inside parameter list
>> include/acpi/video.h:22: warning: its scope is only this definition or declaration, which is probably not what you want
>> include/acpi/video.h: In function 'acpi_video_get_edid':
>> include/acpi/video.h:24: error: 'ENODEV' undeclared (first use in this function)
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> we already have a patch at
> http://marc.info/?l=linux-kernel&m=128369371631933&w=2
> Not sure if Len has applied it or not.
> Anyway, thanks for the patch. :)
Good. Thanks for the info.
> -rui
>> ---
>> include/acpi/video.h | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> --- lnx-2637-rc2.orig/include/acpi/video.h
>> +++ lnx-2637-rc2/include/acpi/video.h
>> @@ -1,6 +1,10 @@
>> #ifndef __ACPI_VIDEO_H
>> #define __ACPI_VIDEO_H
>>
>> +#include <linux/errno.h>
>> +
>> +struct acpi_device;
>> +
>> #define ACPI_VIDEO_DISPLAY_CRT 1
>> #define ACPI_VIDEO_DISPLAY_TV 2
>> #define ACPI_VIDEO_DISPLAY_DVI 3
>> --
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-11-17 16:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 3:12 Linux 2.6.37-rc2 Linus Torvalds
2010-11-16 20:35 ` Zimny Lech
2010-11-17 0:59 ` [PATCH] acpi: fix acpi/video.h error and warning when PM is not enabled Randy Dunlap
2010-11-17 1:29 ` Zhang Rui
2010-11-17 16:06 ` Randy Dunlap [this message]
2010-11-17 1:00 ` [PATCH] cciss: fix build for PROC_FS disabled Randy Dunlap
2010-11-17 2:56 ` Linus Torvalds
2010-11-17 10:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE3FD80.7010808@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).