From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755861Ab1DFReb (ORCPT ); Wed, 6 Apr 2011 13:34:31 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:26069 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754502Ab1DFRea (ORCPT ); Wed, 6 Apr 2011 13:34:30 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6308"; a="84113094" Message-ID: <4D9CA418.2030107@codeaurora.org> Date: Wed, 06 Apr 2011 10:34:16 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: Mattias Wallin CC: Russell King , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Saravana Kannan , Andrew Morton , Linus Walleij Subject: Re: [PATCHv5 1/3] ARM: Translate delay.S into (mostly) C References: <1302047800-26720-1-git-send-email-sboyd@codeaurora.org> <1302047800-26720-2-git-send-email-sboyd@codeaurora.org> <4D9C2910.6020309@stericsson.com> In-Reply-To: <4D9C2910.6020309@stericsson.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/06/2011 01:49 AM, Mattias Wallin wrote: > On 04/06/2011 01:56 AM, Stephen Boyd wrote: >> +void __udelay(unsigned long usecs) >> +{ >> + __const_udelay(usecs * ((2199023*HZ)>>11)); > > This will overflow if HZ=1000. > If I remember correct I fixed it like this: > __const_udelay(usecs * ((2199023UL*HZ)>>11)); > Thanks. I see that my compiler spits out a warning when HZ is 1000. I'll squash this in before sending to the tracker. Care to send a Tested-by? ----->8-----8<----- diff --git a/arch/arm/lib/delay.c b/arch/arm/lib/delay.c index f664002..e7229bf 100644 --- a/arch/arm/lib/delay.c +++ b/arch/arm/lib/delay.c @@ -80,6 +80,6 @@ EXPORT_SYMBOL(__const_udelay); */ void __udelay(unsigned long usecs) { - __const_udelay(usecs * ((2199023*HZ)>>11)); + __const_udelay(usecs * ((2199023UL*HZ)>>11)); } EXPORT_SYMBOL(__udelay); -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.