From: Michal Marek <mmarek@suse.cz>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kbuild@vger.kernel.org
Subject: Re: [RFC][PATCH 07/11] kbuild/recordmcount: Add RECORDMCOUNT_WARN to warn about mcount callers
Date: Thu, 21 Apr 2011 22:40:09 +0200 [thread overview]
Message-ID: <4DB09629.7080008@suse.cz> (raw)
In-Reply-To: <20110421023738.714956282@goodmis.org>
On 21.4.2011 04:28, Steven Rostedt wrote:
> +ifeq ("$(origin RECORDMCOUNT_WARN)", "command line")
> + RECORDMCOUNT_FLAGS = -w
> +endif
RECORDMCOUNT_WARN is IMO unlikely to be used with some other meaning in
the environment, so I think you can drop the origin check. Nevertheless
Acked-by: Michal Marek <mmarek@suse.cz>
Michal
next prev parent reply other threads:[~2011-04-21 20:40 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 2:28 [RFC][PATCH 00/11] ftrace/recordmcount: Remove useless mcount calls not being traced Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 01/11] ftrace/trivial: Clean up recordmcount.c to use Linux style comparisons Steven Rostedt
2011-04-21 8:46 ` Alan Cox
2011-04-21 11:36 ` Steven Rostedt
2011-04-21 12:28 ` Steven Rostedt
2011-04-22 15:09 ` John Reiser
2011-04-22 15:52 ` Thiago Farina
2011-04-22 16:05 ` Steven Rostedt
2011-04-26 18:52 ` Thiago Farina
2011-04-26 19:09 ` Steven Rostedt
2011-04-22 16:13 ` Steven Rostedt
2011-04-22 17:40 ` John Reiser
2011-04-22 17:56 ` H. Peter Anvin
2011-05-18 18:31 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:04 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 02/11] ftrace/trivial: Clean up record mcount to use Linux switch style Steven Rostedt
2011-05-18 18:31 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:04 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 03/11] ftrace: Add .kprobe.text section to whitelist for recordmcount.c Steven Rostedt
2011-05-18 18:32 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:05 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 04/11] ftrace/recordmcount: Modify only executable sections Steven Rostedt
2011-05-18 18:32 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:05 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 05/11] ftrace/recordmcount: Make ignored mcount calls into nops at compile time Steven Rostedt
2011-05-18 18:32 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:05 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 06/11] ftrace/recordmcount: Add warning logic to warn on mcount not recorded Steven Rostedt
2011-05-18 18:33 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:06 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 07/11] kbuild/recordmcount: Add RECORDMCOUNT_WARN to warn about mcount callers Steven Rostedt
2011-04-21 2:40 ` Steven Rostedt
2011-04-21 20:40 ` Michal Marek [this message]
2011-04-26 19:08 ` Steven Rostedt
2011-05-18 18:33 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:06 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 08/11] ftrace: Avoid recording mcount on .init sections directly Steven Rostedt
2011-05-18 18:34 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:07 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 09/11] ftrace/x86: Do not trace .discard.text section Steven Rostedt
2011-05-18 18:34 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:07 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 10/11] ftrace/recordmcount: Remove duplicate code to find mcount symbol Steven Rostedt
2011-05-18 18:34 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:07 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 11/11] ftrace/recordmcount: Add helper function get_sym_str_and_relp() Steven Rostedt
2011-05-18 18:35 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:08 ` tip-bot for Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB09629.7080008@suse.cz \
--to=mmarek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).