From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756976Ab1GAOvS (ORCPT ); Fri, 1 Jul 2011 10:51:18 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34847 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756864Ab1GAOvQ (ORCPT ); Fri, 1 Jul 2011 10:51:16 -0400 Message-ID: <4E0DDEE3.3060207@suse.cz> Date: Fri, 01 Jul 2011 16:51:15 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Thunderbird/3.1.10 MIME-Version: 1.0 To: Arnaud Lacombe Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [PATCHv2] kconfig: introduce specialized printer References: <4D10D7DF.7040903@suse.cz> <1305517329-7558-1-git-send-email-lacombar@gmail.com> <20110609130119.GD4612@sepie.suse.cz> In-Reply-To: <20110609130119.GD4612@sepie.suse.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9.6.2011 15:01, Michal Marek wrote: > On Sun, May 15, 2011 at 11:42:09PM -0400, Arnaud Lacombe wrote: >> Make conf_write_symbol() grammar agnostic to be able to use it from different >> code path. These path pass a printer callback which will print a symbol's name >> and its value in different format. >> >> conf_write_symbol()'s job become mostly only to prepare a string for the >> printer. This avoid to have to pass specialized flag to generic >> functions >> >> Signed-off-by: Arnaud Lacombe >> --- >> scripts/kconfig/confdata.c | 268 +++++++++++++++++++++++++++---------------- >> scripts/kconfig/lkc.h | 5 + >> scripts/kconfig/lkc_proto.h | 1 + >> scripts/kconfig/symbol.c | 46 +++++++- >> 4 files changed, 219 insertions(+), 101 deletions(-) >> >> History: >> v2: Address Michal's comment in msg-id<4D10D7DF.7040903@suse.cz>: >> - add brief comment before each printer >> - introduce a `skip_unset' variable in kconfig printer >> - merge inner switch in an if() statement >> - annotate fallthrough >> - fix tristate printer behavior > > Hi, > > below is my merge with current kbuild-2.6.git#kconfig, notably with the > config_is_xxx() stuff (which we should finalize somehow, but that's not > the point here). Please review, thanks. > > > Subject: [PATCH] kconfig: introduce specialized printer > > Rebase of Arnaud's patch on top of "kconfig: autogenerated config_is_xxx > macro". Pushed to kbuild-2.6.git#kconfig. Michal