From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757518Ab1GDNZp (ORCPT ); Mon, 4 Jul 2011 09:25:45 -0400 Received: from mailout02.t-online.de ([194.25.134.17]:43102 "EHLO mailout02.t-online.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757402Ab1GDNZm (ORCPT ); Mon, 4 Jul 2011 09:25:42 -0400 X-Greylist: delayed 1125 seconds by postgrey-1.27 at vger.kernel.org; Mon, 04 Jul 2011 09:25:41 EDT Message-ID: <4E11BAE0.5020208@t-online.de> Date: Mon, 04 Jul 2011 15:06:40 +0200 From: Knut Petersen User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Thunderbird/3.1.10 MIME-Version: 1.0 To: gregkh@suse.de CC: axboe@kernel.dk, kay.sievers@vrfy.org, "David S. Miller" , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [BUG 2.6.38.8] Bisected to commit 5fb46ae7b8c51b05a12c6a66108e8d398c20ee09 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-ID: VOYdyuZcrhLzSwvCY3BGr+EsWd+ucWsNzmeAoMVroI4moesE0cWUrWaG+dfFhcZweI X-TOI-MSGID: c85a4cc5-8417-462d-978d-b3585ae8b7a8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi everybody! An openSuse 11.2 system reliably refused to boot properly with kernel 2.6.38.8 although the prior 2.6.38.y kernels worked fine. After a few seconds booting stopped. Several did help, but a lot of services were not started properly, only the root partition was available. Nothing unusual could be found in the kernel messages. I bisected the problem to commit 5fb46ae7b8c51b05a12c6a66108e8d398c20ee09. That gave me the idea to disconnect the Plextor PX-755A dvd drive and to try 2.6.38.8 again. It booted without problem. As I do use the dvd drive only once or twice a year on that system I checked the hardware - it seems that the drive has a mechanical or optical problem. No kernel can repair a broken dvd drive, but I strongly believe that at least error handling should be restored to something more reasonable. cu, Knut knut@linux:~/git/linux-2.6.38.y> git bisect bad 5fb46ae7b8c51b05a12c6a66108e8d398c20ee09 is the first bad commit commit 5fb46ae7b8c51b05a12c6a66108e8d398c20ee09 Author: Tejun Heo Date: Wed Mar 9 19:54:27 2011 +0100 ide: Convert to bdops->check_events() commit 5b03a1b140e13a28ff6be1526892a9dc538ddef6 upstream. Convert ->media_changed() to the new ->check_events() method. The conversion is mostly mechanical. The only notable change is that cdrom now doesn't generate any event if @slot_nr isn't CDSL_CURRENT. It used to return -EINVAL which would be treated as media changed. As media changer isn't supported anyway, this doesn't make any difference. This makes ide emit the standard disk events and allows kernel event polling. Currently, only MEDIA_CHANGE event is implemented. Adding support for EJECT_REQUEST shouldn't be difficult; however, given that ide driver is already deprecated, it probably is best to leave it alone. Signed-off-by: Tejun Heo Acked-by: Jens Axboe Cc: Kay Sievers Cc: "David S. Miller" Cc: linux-ide@vger.kernel.org Signed-off-by: Greg Kroah-Hartman