From: Cong Wang <amwang@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Paul Clements <Paul.Clements@steeleye.com>,
Jiri Kosina <trivial@kernel.org>
Subject: Re: [PATCH] nbd: some trivial improvements
Date: Tue, 09 Aug 2011 15:13:55 +0800 [thread overview]
Message-ID: <4E40DE33.1070208@redhat.com> (raw)
In-Reply-To: <1312821425.1643.11.camel@Joe-Laptop>
于 2011年08月09日 00:37, Joe Perches 写道:
> On Mon, 2011-08-08 at 17:00 +0800, Amerigo Wang wrote:
>> This patch 1) uses task_pid_nr(current) to get the pid of current process,
>> 2) replaces sysfs_create_file() with device_create_file(), 3) lower
>> the loglevel of an error message.
>
> Just trivia:
>
>> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> []
>> @@ -405,10 +405,10 @@ static int nbd_do_it(struct nbd_device *lo)
>>
>> BUG_ON(lo->magic != LO_MAGIC);
>>
>> - lo->pid = current->pid;
>> - ret = sysfs_create_file(&disk_to_dev(lo->disk)->kobj,&pid_attr.attr);
>> + lo->pid = task_pid_nr(current);
>> + ret = device_create_file(disk_to_dev(lo->disk),&pid_attr);
>> if (ret) {
>> - printk(KERN_ERR "nbd: sysfs_create_file failed!");
>> + printk(KERN_ERR "nbd: device_create_file failed!");
>
> Missing "\n".
>
Ok, I didn't notice this, will fix it.
Thanks.
next prev parent reply other threads:[~2011-08-09 7:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 9:00 [PATCH] nbd: some trivial improvements Amerigo Wang
2011-08-08 16:37 ` Joe Perches
2011-08-09 7:13 ` Cong Wang [this message]
2011-08-08 17:20 ` Greg KH
2011-08-09 7:16 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E40DE33.1070208@redhat.com \
--to=amwang@redhat.com \
--cc=Paul.Clements@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).