From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751368AbbCOImu (ORCPT ); Sun, 15 Mar 2015 04:42:50 -0400 Received: from ozlabs.org ([103.22.144.67]:40552 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751391AbbCOImo (ORCPT ); Sun, 15 Mar 2015 04:42:44 -0400 User-Agent: K-9 Mail for Android In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH 2/2] selftests/timers: change to use shared logic to run and install tests From: Michael Ellerman Date: Sun, 15 Mar 2015 19:42:37 +1100 To: Shuah Khan , john.stultz@linaro.org, tglx@linutronix.de, mpe@ellerman.id.au CC: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <4E4E8162-A30D-4460-BF55-12C269760577@ellerman.id.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14 March 2015 09:57:51 GMT+11:00, Shuah Khan wrote: >Change the timers Makefile to make use of shared run and install >logic in lib.mk. Destructive tests are installed. Regular tests >are emited to run_kselftest script to match the run_tests behavior. > >Signed-off-by: Shuah Khan >--- > tools/testing/selftests/timers/Makefile | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > >diff --git a/tools/testing/selftests/timers/Makefile >b/tools/testing/selftests/timers/Makefile >index 9da3498..61e7284 100644 >--- a/tools/testing/selftests/timers/Makefile >+++ b/tools/testing/selftests/timers/Makefile >@@ -7,19 +7,21 @@ bins = posix_timers nanosleep inconsistency-check >nsleep-lat raw_skew \ > alarmtimer-suspend change_skew skew_consistency clocksource-switch \ > leap-a-day leapcrash set-tai set-2038 > >+TEST_PROGS = posix_timers nanosleep nsleep-lat set-timer-lat >mqueue-lat \ >+ inconsistency-check raw_skew >+TEST_FILES = threadtest alarmtimer-suspend valid-adjtimex change_skew >\ >+ skew_consistency clocksource-switch leap-a-day leapcrash \ >+ set-tai set-2038 >+ >+RUN_TESTS_WITH_ARGS := ./threadtest -t 30 -n 8 || echo "selftests: >threadtest [FAIL]" You shouldn't need this separate variable. As long as you override RUN_TESTS after you include lib.mk you can include the default value, eg: override RUN_TESTS := $(RUN_TESTS) ./threadtest -t 30 -n 8 || echo "selftests: threadtest [FAIL]" I'll test that in the morning and send a proper patch. cheers -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.