From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933624Ab1JZQ2J (ORCPT ); Wed, 26 Oct 2011 12:28:09 -0400 Received: from oproxy9.bluehost.com ([69.89.24.6]:57290 "HELO oproxy9.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S933014Ab1JZQ2H (ORCPT ); Wed, 26 Oct 2011 12:28:07 -0400 Message-ID: <4EA8350D.1080003@xenotime.net> Date: Wed, 26 Oct 2011 09:27:57 -0700 From: Randy Dunlap Organization: YPO4 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20111001 Thunderbird/7.0.1 MIME-Version: 1.0 To: Stefan Richter CC: Herbert Xu , Stephen Rothwell , linux-next@vger.kernel.org, LKML , Linus , linux-crypto@vger.kernel.org Subject: Re: linux-next: Tree for Oct 25 (crypto) References: <20111025203628.40a1b8a475e32053aa34dabe@canb.auug.org.au> <4EA75759.3050900@xenotime.net> <20111026062717.GA10230@gondor.apana.org.au> <20111026143347.462fea95@stein> In-Reply-To: <20111026143347.462fea95@stein> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/11 05:33, Stefan Richter wrote: > On Oct 26 Herbert Xu wrote: >> On Tue, Oct 25, 2011 at 05:42:01PM -0700, Randy Dunlap wrote: >>> On 10/25/11 02:36, Stephen Rothwell wrote: >>>> Hi all, >>> >>> >>> When CONFIG_NET is not enabled: >> >> Thanks, I'll add this patch. >> >> diff --git a/crypto/Kconfig b/crypto/Kconfig >> index a8442dc..259dea9 100644 >> --- a/crypto/Kconfig >> +++ b/crypto/Kconfig >> @@ -103,6 +103,7 @@ config CRYPTO_MANAGER2 >> config CRYPTO_USER >> tristate "Userspace cryptographic algorithm configuration" >> select CRYPTO_MANAGER >> + select NET >> help >> Userapace configuration for cryptographic instantiations such as >> cbc(aes). >> >> Cheers, > > If you do it this way, you also need to select everything on which NET > depends on. In v3.1, that would be (only) NLATTR which in turn does not > depend on anything else. > > Furthermore, I am noticing in v3.1 that CRYPTO_MANAGER selects > CRYPTO_MANAGER2 which in turn has the following dependencies: > > config CRYPTO_MANAGER2 > def_tristate CRYPTO_MANAGER || (CRYPTO_MANAGER!=n && CRYPTO_ALGAPI=y) > select CRYPTO_AEAD2 > select CRYPTO_HASH2 > select CRYPTO_BLKCIPHER2 > select CRYPTO_PCOMP2 > > I think you need to copy those dependencies into config CRYPTO_MANAGER. That's correct, but it's better not to "select" an entire subsystem like NET at all. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***