From: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Takashi Iwai <tiwai@suse.de>,
perex@perex.cz, linux-kernel@vger.kernel.org, "Wang,
Qi" <qi.wang@intel.com>, "Wang, Yong Y" <yong.y.wang@intel.com>,
"Clark, Joel" <joel.clark@intel.com>,
"Ewe, Kok Howg" <kok.howg.ewe@intel.com>,
Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] Add SoundCard driver for OKI SEMICONDUCTOR ML7213 IOH
Date: Thu, 10 Nov 2011 14:00:22 +0900 [thread overview]
Message-ID: <4EBB5A66.2020800@dsn.lapis-semi.com> (raw)
In-Reply-To: <20111108143818.GA5632@opensource.wolfsonmicro.com>
(2011/11/08 23:38), Mark Brown wrote:
> On Tue, Nov 08, 2011 at 06:03:53PM +0900, Tomoya MORINAGA wrote:
>
> So, I started looking at this but...
>
>> struct snd_ml7213i2s_pcm {
>> enum snd_soc_control_type control_type;
>> struct snd_ml7213i2s *ml7213i2s;
>> spinlock_t lock;
>> unsigned int irq_pos;
>> unsigned int buf_pos;
>> struct snd_pcm_substream *substream;
>> struct cbdata cbd; /* i2s callback info */
>> unsigned int channels;
>> unsigned int rw;
>> unsigned int rate;
>> unsigned int ch;
>> unsigned int setup_flag;
>> unsigned int format;
>> unsigned int bclkfs;
>> struct mutex i2c_mutex;
>> };
>
> ...this looks *really* confused, there's things in here which are a mix
> of DMA controller and CODEC driver things. The CODEC and DMA drivers
> shouldn't know anything about each other, let alone be referencing the
> same data structure.
Let me clarify your saying.
I couldn't understand what your "DMA controller" mean.
Which "snd_ml7213i2s_pcm" structure member do you mean ?
--
tomoya
ROHM Co., Ltd.
next prev parent reply other threads:[~2011-11-10 5:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <70D251FDDC55405882A8447CC455D56E@hacdom.okisemi.com>
[not found] ` <8486F61FC3B94B908BFE654234DD6C97@hacdom.okisemi.com>
2011-10-17 4:28 ` [PATCH] Add SoundCard driver for OKI SEMICONDUCTOR ML7213 IOH Tomoya MORINAGA
2011-10-21 14:16 ` Takashi Iwai
2011-10-24 12:12 ` Tomoya MORINAGA
2011-10-24 12:20 ` Mark Brown
2011-11-08 9:03 ` Tomoya MORINAGA
2011-11-08 10:39 ` Mark Brown
2011-11-09 2:56 ` Tomoya MORINAGA
2011-11-08 14:38 ` Mark Brown
2011-11-10 5:00 ` Tomoya MORINAGA [this message]
2011-11-10 11:22 ` Mark Brown
2011-07-06 10:27 Toshiharu Okada
2011-07-06 11:06 ` Takashi Iwai
2011-07-07 7:54 ` Toshiharu Okada
2011-07-07 9:00 ` Takashi Iwai
2011-07-07 12:35 ` Toshiharu Okada
2011-07-07 16:38 ` Takashi Iwai
2011-07-08 10:52 ` Toshiharu Okada
2011-07-09 1:34 ` Mark Brown
2011-07-09 7:40 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBB5A66.2020800@dsn.lapis-semi.com \
--to=tomoya-linux@dsn.lapis-semi.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=perex@perex.cz \
--cc=qi.wang@intel.com \
--cc=tiwai@suse.de \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).