From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932353Ab1KQPoa (ORCPT ); Thu, 17 Nov 2011 10:44:30 -0500 Received: from mail-yw0-f46.google.com ([209.85.213.46]:52468 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932196Ab1KQPo2 (ORCPT ); Thu, 17 Nov 2011 10:44:28 -0500 Message-ID: <4EC52BCF.7020609@gmail.com> Date: Thu, 17 Nov 2011 09:44:15 -0600 From: Rob Herring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: Peter De Schrijver CC: Stephen Warren , linux-kernel@vger.kernel.org, Marc Dietrich , Grant Likely , linux-tegra@vger.kernel.org, Colin Cross , Olof Johansson , Russell King , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm/tegra: convert tegra20 to GIC devicetree binding References: <1321542430-17971-1-git-send-email-pdeschrijver@nvidia.com> In-Reply-To: <1321542430-17971-1-git-send-email-pdeschrijver@nvidia.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/17/2011 09:07 AM, Peter De Schrijver wrote: > Convert tegra20 IRQ intialization to the GIC devicetree binding. Modify the > interrupt definitions in the dts files according to > Documentation/devicetree/bindings/arm/gic.txt > > Signed-off-by: Peter De Schrijver One minor comment below, but otherwise: Acked-by: Rob Herring > --- > arch/arm/boot/dts/tegra-paz00.dts | 2 +- > arch/arm/boot/dts/tegra20.dtsi | 52 ++++++++++++++++++------------------ > arch/arm/mach-tegra/irq.c | 18 +++++++++++- > 3 files changed, 43 insertions(+), 29 deletions(-) > > diff --git a/arch/arm/boot/dts/tegra-paz00.dts b/arch/arm/boot/dts/tegra-paz00.dts > index 15a949f..7ff8f6f 100644 > --- a/arch/arm/boot/dts/tegra-paz00.dts > +++ b/arch/arm/boot/dts/tegra-paz00.dts > @@ -32,7 +32,7 @@ > #size-cells = <0>; > compatible = "nvidia,nvec"; > reg = <0x7000C500 0x100>; > - interrupts = <124>; > + interrupts = <0 92 0x04>; > clock-frequency = <80000>; > request-gpios = <&gpio 170 0>; > slave-addr = <138>; > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > index 795b921..cd01b01 100644 > --- a/arch/arm/boot/dts/tegra20.dtsi > +++ b/arch/arm/boot/dts/tegra20.dtsi > @@ -5,9 +5,9 @@ > interrupt-parent = <&intc>; > > intc: interrupt-controller@50041000 { > - compatible = "nvidia,tegra20-gic"; > + compatible = "arm,cortex-a9-gic"; > interrupt-controller; You should add an "interrupt-parent;" here so the gic's parent is null and not the gic. Rob > - #interrupt-cells = <1>; > + #interrupt-cells = <3>; > reg = < 0x50041000 0x1000 >, > < 0x50040100 0x0100 >; > };