From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751516Ab1LSI54 (ORCPT ); Mon, 19 Dec 2011 03:57:56 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:1158 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880Ab1LSI5y (ORCPT ); Mon, 19 Dec 2011 03:57:54 -0500 Message-ID: <4EEEFC54.10700@parallels.com> Date: Mon, 19 Dec 2011 12:56:52 +0400 From: Stanislav Kinsbursky User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15 MIME-Version: 1.0 To: "Eric W. Biederman" CC: "Trond.Myklebust@netapp.com" , "linux-nfs@vger.kernel.org" , Pavel Emelianov , "neilb@suse.de" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , James Bottomley , "bfields@fieldses.org" , "davem@davemloft.net" , "devel@openvz.org" Subject: Re: [PATCH 01/11] SYSCTL: export root and set handling routines References: <20111214103602.3991.20990.stgit@localhost6.localdomain6> <20111214104449.3991.61989.stgit@localhost6.localdomain6> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 18.12.2011 02:25, Eric W. Biederman пишет: > Stanislav Kinsbursky writes: > >> These routines are required for making SUNRPC sysctl's per network namespace >> context. > > Why does sunrpc require it's own sysctl root? You should be able to use > the generic per network namespace root and call it good. > > What makes register_net_sysctl_table and register_net_sysctl_ro_table > unsuitable for sunrpc. I skimmed through your patches and I haven't > seen anything obvious. > > Eric > Hello, Eric. Sorry for the lack of information. I was considering two ways how to make these sysctl per net ns: 1) Use register_net_sysctl_table and register_net_sysctl_ro_table as you mentioned. This was easy and cheap, but also means, than all user-space programs, tuning SUNRPC will be broken (since all sysctl currently located in"/proc/sys/sunprc/"). 2) Export sysctl root creation routines and make per-net SUNRPC sysctl root. This approach allows to make any part of sysctl tree per namespace context and thus leave user-space stuff unchanged. BTW, NFS and LockD also have it's sysctls ("/proc/sys/fs/nfs/"). And also because of them I've decided, that it would be better to export SYSCTL root creation routines instead of breaking compatibility for all NFS layers by moving all sysctl under /proc/sys/net/ directory. Do you feel that it was a bad decision? > >> Signed-off-by: Stanislav Kinsbursky >> >> --- >> include/linux/sysctl.h | 1 + >> kernel/sysctl.c | 11 +++++++++++ >> 2 files changed, 12 insertions(+), 0 deletions(-) >> >> diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h >> index 703cfa3..be586a9 100644 >> --- a/include/linux/sysctl.h >> +++ b/include/linux/sysctl.h >> @@ -1084,6 +1084,7 @@ struct ctl_path { >> }; >> >> void register_sysctl_root(struct ctl_table_root *root); >> +void unregister_sysctl_root(struct ctl_table_root *root); >> struct ctl_table_header *__register_sysctl_paths( >> struct ctl_table_root *root, struct nsproxy *namespaces, >> const struct ctl_path *path, struct ctl_table *table); >> diff --git a/kernel/sysctl.c b/kernel/sysctl.c >> index ae27196..fb016a9 100644 >> --- a/kernel/sysctl.c >> +++ b/kernel/sysctl.c >> @@ -1700,6 +1700,15 @@ void register_sysctl_root(struct ctl_table_root *root) >> list_add_tail(&root->root_list,&sysctl_table_root.root_list); >> spin_unlock(&sysctl_lock); >> } >> +EXPORT_SYMBOL_GPL(register_sysctl_root); >> + >> +void unregister_sysctl_root(struct ctl_table_root *root) >> +{ >> + spin_lock(&sysctl_lock); >> + list_del(&root->root_list); >> + spin_unlock(&sysctl_lock); >> +} >> +EXPORT_SYMBOL_GPL(unregister_sysctl_root); >> >> /* >> * sysctl_perm does NOT grant the superuser all rights automatically, because >> @@ -1925,6 +1934,7 @@ struct ctl_table_header *__register_sysctl_paths( >> >> return header; >> } >> +EXPORT_SYMBOL_GPL(__register_sysctl_paths); >> >> /** >> * register_sysctl_table_path - register a sysctl table hierarchy >> @@ -2007,6 +2017,7 @@ void setup_sysctl_set(struct ctl_table_set *p, >> p->parent = parent ? parent :&sysctl_table_root.default_set; >> p->is_seen = is_seen; >> } >> +EXPORT_SYMBOL_GPL(setup_sysctl_set); >> >> #else /* !CONFIG_SYSCTL */ >> struct ctl_table_header *register_sysctl_table(struct ctl_table * table) >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best regards, Stanislav Kinsbursky