From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759206Ab2AFUoD (ORCPT ); Fri, 6 Jan 2012 15:44:03 -0500 Received: from e24smtp03.br.ibm.com ([32.104.18.24]:34117 "EHLO e24smtp03.br.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759112Ab2AFUn7 (ORCPT ); Fri, 6 Jan 2012 15:43:59 -0500 Message-ID: <4F075D02.3010407@linux.vnet.ibm.com> Date: Fri, 06 Jan 2012 18:43:46 -0200 From: Lucas Kannebley Tavares User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.1.16-1.fc14 Thunderbird/3.1.16 MIME-Version: 1.0 To: Thadeu Lima de Souza Cascardo CC: Breno Leitao , Alan Cox , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Greg KH Subject: Re: [PATCH] jsm: Fixed EEH recovery error References: <1315834565-9280-1-git-send-email-lucaskt@linux.vnet.ibm.com> <20110912153508.GA8851@oc1711230544.ibm.com> In-Reply-To: <20110912153508.GA8851@oc1711230544.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit x-cbid: 12010620-9254-0000-0000-000007C07702 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/2011 12:35 PM, Thadeu Lima de Souza Cascardo wrote: > On Mon, Sep 12, 2011 at 10:36:05AM -0300, Lucas Kannebley Tavares wrote: >> There was an error on the jsm driver that would cause it to be unable to >> recover after a second error is detected. >> >> At the first error, the device recovers properly: >> >> [72521.485691] EEH: Detected PCI bus error on device 0003:02:00.0 >> [72521.485695] EEH: This PCI device has failed 1 times in the last hour: >> ... >> [72532.035693] ttyn3 at MMIO 0x0 (irq = 49) is a jsm >> [72532.105689] jsm: Port 3 added >> >> However, at the second error, it cascades until EEH disables the device: >> >> [72631.229549] Call Trace: >> ... >> [72641.725687] jsm: Port 3 added >> [72641.725695] EEH: Detected PCI bus error on device 0003:02:00.0 >> [72641.725698] EEH: This PCI device has failed 3 times in the last hour: >> >> It was caused because the PCI state was not being saved after the first >> restore. Therefore, at the second recovery the PCI state would not be >> restored. >> >> Signed-off-by: Lucas Kannebley Tavares >Signed-off-by: Breno Leitao > Acked-by: Thadeu Lima de Souza Cascardo Adding Greg to the CC list. It wasn't added earlier because get_maintainers.pl only listed Alan's name. I apologize for the delay. This is a bugfix to EEH handling on jsm. > >> --- >> drivers/tty/serial/jsm/jsm_driver.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/tty/serial/jsm/jsm_driver.c b/drivers/tty/serial/jsm/jsm_driver.c >> index 96da178..8941b15 100644 >> --- a/drivers/tty/serial/jsm/jsm_driver.c >> +++ b/drivers/tty/serial/jsm/jsm_driver.c >> @@ -270,6 +270,7 @@ static void jsm_io_resume(struct pci_dev *pdev) >> struct jsm_board *brd = pci_get_drvdata(pdev); >> >> pci_restore_state(pdev); >> + pci_save_state(pdev); >> >> jsm_uart_port_init(brd); >> } >> -- >> 1.7.4.4 >>