From: "Németh Márton" <nm127@freemail.hu>
To: Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: PATCH] use void __iomem * pointers for ioread32()/iowrite32()
Date: Wed, 18 Jan 2012 07:05:18 +0100 [thread overview]
Message-ID: <4F16611E.3050303@freemail.hu> (raw)
In-Reply-To: <CACxGe6t2xtm-T43cBcbaqTrnPST9+R8E7dhq1rJnC+4P2__JRQ@mail.gmail.com>
From: Márton Németh <nm127@freemail.hu>
The address pointer of ioread32()/iowrite32() functions are
of type "void __iomem *". Use matching variable type.
For details on __iomem see [1] and [2].
References:
[1] A new I/O memory access mechanism (Sep 15, 2004)
http://lwn.net/Articles/102232/
[2] Being more anal about iospace accesses (Sep 15, 2004)
http://lwn.net/Articles/102240/
Signed-off-by: Márton Németh <nm127@freemail.hu>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpio-pch.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index 68fa55e..84b7f28 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -231,7 +231,7 @@ static void pch_gpio_setup(struct pch_gpio *chip)
static int pch_irq_type(struct irq_data *d, unsigned int type)
{
u32 im;
- u32 __iomem *im_reg;
+ void __iomem *im_reg;
u32 ien;
u32 im_pos;
int ch;
--
1.7.2.5
next prev parent reply other threads:[~2012-01-18 6:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 10:32 [PATCH 1/2] gpio-pch: cleanup __iomem annotation usage Németh Márton
2012-01-17 8:14 ` Linus Walleij
2012-01-17 8:32 ` Németh Márton
2012-01-17 9:01 ` Linus Walleij
2012-01-17 20:43 ` [PATCH 1/2 v2] " Németh Márton
2012-01-17 22:49 ` [PATCH 1/2] " Grant Likely
2012-01-18 6:05 ` Németh Márton [this message]
2012-01-18 6:18 ` PATCH] use void __iomem * pointers for ioread32()/iowrite32() Al Viro
2012-01-18 21:07 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F16611E.3050303@freemail.hu \
--to=nm127@freemail.hu \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).