From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932650Ab2ASRxN (ORCPT ); Thu, 19 Jan 2012 12:53:13 -0500 Received: from terminus.zytor.com ([198.137.202.10]:37410 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932485Ab2ASRxK (ORCPT ); Thu, 19 Jan 2012 12:53:10 -0500 Message-ID: <4F18584F.7060603@zytor.com> Date: Thu, 19 Jan 2012 09:52:15 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: Michael D Labriola CC: Alan Cox , Kushal Koolwal , linux-kernel@vger.kernel.org, michael.d.labriola@gmail.com, Ingo Molnar , Matthew Garrett , support@versalogic.com, Thomas Gleixner , x86@kernel.org Subject: Re: [PATCH] x86, reboot: skip DMI checks if reboot set by user References: <20120117195841.48fe8236@pyramind.ukuu.org.uk> <20120119154504.710e202e@pyramind.ukuu.org.uk> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/19/2012 09:46 AM, Michael D Labriola wrote: > > Random question... why do we have a reboot_init function that does DMI > checking with reboot_dmi_table (callbacks are mostly set_bios_reboot, but > there is a single set_kbd_reboot) and also a pci_reboot_init which does > the DMI check again using a separate pci_reboot_dmi_table (all callbacks > are to set_pci_reboot)? > > Wouldn't it make more sense to do a single DMI scan using one big table? > Yes, and such a patch would be appreciated. The reason it is as it is dates back to before the 32-64 bit unification, as far as I know. (BIOS reboot is currently not supported on 64 bits, mainly.) -hpa