From: Shubhrajyoti <shubhrajyoti@ti.com>
To: Kevin Hilman <khilman@ti.com>
Cc: linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 2/2] OMAP : serial : Check for error in get_context_loss_count
Date: Fri, 20 Jan 2012 11:29:20 +0530 [thread overview]
Message-ID: <4F1902B8.5020000@ti.com> (raw)
In-Reply-To: <87hazrti1c.fsf@ti.com>
On Friday 20 January 2012 04:29 AM, Kevin Hilman wrote:
> Shubhrajyoti D <shubhrajyoti@ti.com> writes:
>
>> In serial_omap_runtime_resume in case of errors returned by
>> get_context_loss_count print a warning and do a restore.
>>
>> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> These two patches should be combined into a single patch.
>
OK I will combine. I had split as the one was a serial driver and one
for omap
maintainer.
However I agree that they should be combined.
> Also, please Cc Govindraj since he's the maintainer of this driver and
> should Ack.
will do that
> Thanks,
>
> Kevin
>
>> ---
>> applies on Tony's uart branch
>>
>> drivers/tty/serial/omap-serial.c | 10 ++++++++--
>> 1 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
>> index 29fe6fd..6008612 100644
>> --- a/drivers/tty/serial/omap-serial.c
>> +++ b/drivers/tty/serial/omap-serial.c
>> @@ -1602,10 +1602,16 @@ static int serial_omap_runtime_resume(struct device *dev)
>>
>> if (up) {
>> if (pdata->get_context_loss_count) {
>> - u32 loss_cnt = pdata->get_context_loss_count(dev);
>> + int loss_cnt = pdata->get_context_loss_count(dev);
>>
>> - if (up->context_loss_cnt != loss_cnt)
>> + if (loss_cnt < 0) {
>> + dev_err(dev,
>> + "get_context_loss_count failed : %d\n",
>> + loss_cnt);
>> serial_omap_restore_context(up);
>> + } else if (up->context_loss_cnt != loss_cnt) {
>> + serial_omap_restore_context(up);
>> + }
>> }
>>
>> /* Errata i291 */
prev parent reply other threads:[~2012-01-20 5:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 14:03 [PATCH RFC 1/2] ARM : OMAP : serial : Make context_loss_cnt signed Shubhrajyoti D
2012-01-12 14:03 ` [PATCH RFC 2/2] OMAP : serial : Check for error in get_context_loss_count Shubhrajyoti D
2012-01-19 22:59 ` Kevin Hilman
2012-01-20 5:59 ` Shubhrajyoti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1902B8.5020000@ti.com \
--to=shubhrajyoti@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).