From: Jiri Slaby <jirislaby@gmail.com>
To: Simon Glass <sjg@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Jiri Kosina <trivial@kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-serial@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2] serial: trivial checkpatch fixes in drivers/tty/serial/8250.c
Date: Fri, 20 Jan 2012 16:43:39 +0100 [thread overview]
Message-ID: <4F198BAB.3010706@gmail.com> (raw)
In-Reply-To: <1327019067-19115-1-git-send-email-sjg@chromium.org>
On 01/20/2012 01:24 AM, Simon Glass wrote:
> @@ -2006,8 +2010,8 @@ static int serial8250_startup(struct uart_port *port)
> */
> if (!(up->port.flags & UPF_BUGGY_UART) &&
> (serial_inp(up, UART_LSR) == 0xff)) {
> - printk_ratelimited(KERN_INFO "ttyS%d: LSR safety check engaged!\n",
> - serial_index(&up->port));
> + pr_info_ratelimited(
FWIW I hate these macros. Beginners ask what the heck stands "pr" for?
> @@ -3053,8 +3063,8 @@ static int __devinit serial8250_probe(struct platform_device *dev)
> port.irqflags |= irqflag;
> ret = serial8250_register_port(&port);
> if (ret < 0) {
> - dev_err(&dev->dev, "unable to register port at index %d "
> - "(IO%lx MEM%llx IRQ%d): %d\n", i,
> + dev_err(&dev->dev, "unable to register port at "
> + "index %d (IO%lx MEM%llx IRQ%d): %d\n", i,
Nack to this. It makes grepping harder.
thanks,
--
js
prev parent reply other threads:[~2012-01-20 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 19:37 [PATCH] serial: trivial checkpatch fixes in drivers/tty/serial/8250.c Simon Glass
2012-01-19 19:49 ` Joe Perches
2012-01-20 0:23 ` Simon Glass
2012-01-20 0:24 ` [PATCH v2] " Simon Glass
2012-01-20 15:43 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F198BAB.3010706@gmail.com \
--to=jirislaby@gmail.com \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sjg@chromium.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).