From: Michael Tokarev <mjt@tls.msk.ru>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>, Paolo Bonzini <pbonzini@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
James Bottomley <JBottomley@parallels.com>,
mmarek@suse.cz
Subject: Re: Ioctl warning for a partition
Date: Fri, 27 Jan 2012 03:56:24 +0400 [thread overview]
Message-ID: <4F21E828.8090502@msgid.tls.msk.ru> (raw)
In-Reply-To: <CA+55aFwkRhsdAYwP-S5_qPkRX=dMSnxv5Ow1ULaSJjKe3aTy2w@mail.gmail.com>
On 27.01.2012 03:01, Linus Torvalds wrote:
> On Thu, Jan 26, 2012 at 2:30 PM, Jan Kara <jack@suse.cz> wrote:
>>
>> It's easy enough to silence the warning the same way as
>> CDROM_GET_CAPABILITY since the ioctl is safe but it's not so simple for
>> 32-bit userspace. MTIOCGET32 is defined only in fs/compat_ioctl.c so we
>> cannot easily add it to scsi_verify_blk_ioctl(). Any opinion how to cleanly
>> solve this? The only idea I had was to define compat structures and ioctl
>> numbers in a special header and use it both in fs/compat_ioctl.c and in
>> block/scsi_ioctl.c.
>
> I suspect we can just remove the warning entirely - once we've gotten
> enough coverage with the -rc kernels that people (me in particular)
> are happy that no normal load really needs it, and returning an error
> is fine.
>
> So I don't really consider the warning to be something long-term - I
> wanted it to make sure that some random binary in some odd
> distribution wouldn't break in mysterious ways that would take a lot
> of debugging to find. And so that we really know what we end up
> blocking in practice.
>
> I'm not sure how good the -rc kernel coverage is, but I think it's
> good enough that we can drop the warning before doing a real 3.3
> release. And I don't think the stable kernel versions ever got that
> warning printout, did they? That would be great for coverage, of
> course, if they did.
They did, 3.0 and 3.2.
For example, 3.0.18:
[ 610.488489] kvm: sending ioctl 5326 to a partition!
[ 610.488540] kvm: sending ioctl 80200204 to a partition!
mdadm ioctls reported in various places apparently got fixed by
ENOTTY/ENOIOCTLCMD change.
Thanks,
/mjt
next prev parent reply other threads:[~2012-01-26 23:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 22:30 Ioctl warning for a partition Jan Kara
2012-01-26 23:01 ` Linus Torvalds
2012-01-26 23:56 ` Michael Tokarev [this message]
2012-01-27 19:28 ` Henrique de Moraes Holschuh
2012-01-27 19:37 ` Henrique de Moraes Holschuh
2012-01-28 10:22 ` Paolo Bonzini
2012-01-28 14:41 ` Henrique de Moraes Holschuh
2012-01-27 8:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F21E828.8090502@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=JBottomley@parallels.com \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=pbonzini@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).