From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790Ab2A0KG1 (ORCPT ); Fri, 27 Jan 2012 05:06:27 -0500 Received: from mail-ww0-f44.google.com ([74.125.82.44]:62648 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753738Ab2A0KGY (ORCPT ); Fri, 27 Jan 2012 05:06:24 -0500 Message-ID: <4F22771B.3030402@monstr.eu> Date: Fri, 27 Jan 2012 11:06:19 +0100 From: Michal Simek Reply-To: monstr@monstr.eu User-Agent: Thunderbird 2.0.0.22 (X11/20090625) MIME-Version: 1.0 To: LKML CC: Ohad Ben-Cohen , John Williams , linux-arm , "Grosen, Mark" , Arnd Bergmann , Grant Likely , devicetree-discuss@lists.ozlabs.org Subject: Re: remoteproc: Load coprocessor code to the specific main memory location References: <4F1EE861.4030405@monstr.eu> <4F1FF870.3000105@monstr.eu> <4F200F64.9060203@monstr.eu> <4F212E9E.9060807@monstr.eu> In-Reply-To: <4F212E9E.9060807@monstr.eu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Simek wrote: > Ohad Ben-Cohen wrote: >> On Wed, Jan 25, 2012 at 4:19 PM, Michal Simek wrote: >>> I started with pur vanilla kernel and patches from your tree >>> git://git.kernel.org/pub/scm/linux/kernel/git/ohad/remoteproc.git >>> for-next branch >>> but then I had to moved to for-next-acked-merged because in the origin >>> one were some problems. >> >> Unlike for-next-acked-merged, the other branches aren't rebased and >> therefore have merge conflicts with 3.3 material; that's intentional. >> >>> Do you have any kernel tree with CMA just for sure? >> >> Not a 3.3-based one, so I recommend you to just merge Marek's branch >> directly. >> >> I'll soon create a full-fledged 3.3 branch though, so you may want to >> wait a bit until I get to it. > > I have done it and tested. It works as expected. Thanks. > I have created region at phys addr 0x10000000 with selected size. > I had to move carveout in resource table to be first in this area. > Also removed that copying from kick function. > > > > I have one small problem which is that physical address is 0x10000000 > which means that firmware entry point is the same. > In rproc_load_segments is da composed from phdr->p_paddr which is > 0x10000000. > And code is designed that this load addr is offset. > > Here is the code: > /* go through the available ELF segments */ > for (i = 0; i < ehdr->e_phnum; i++, phdr++) { > u32 da = phdr->p_paddr; // OFFSET 0x10000000 > u32 memsz = phdr->p_memsz; > > But for my case is physical address correct and it is not offset > 0x10000000. > I have created temporary fix which substract virtual address to get > correct da. > > u32 da = phdr->p_paddr - phdr->p_vaddr; > > What should be correct solution? Just follow up. I have find out that moving to 0x10000000 offset will be problematic because there must be vector table at 0x0. IIUC Linux remaps reset vectors to 0xffff0000 offset through cp15 reg in bootup code. Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian