From: Timur Tabi <timur@freescale.com>
To: Dmitry Artamonow <mad_soft@inbox.ru>
Cc: <linux-watchdog@vger.kernel.org>,
Kumar Gala <galak@kernel.crashing.org>,
Wim Van Sebroeck <wim@iguana.be>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] watchdog: fix GETTIMEOUT ioctl in booke_wdt
Date: Fri, 27 Jan 2012 15:22:56 -0600 [thread overview]
Message-ID: <4F2315B0.2010507@freescale.com> (raw)
In-Reply-To: <4F231234.5030007@freescale.com>
Timur Tabi wrote:
> Dmitry Artamonow wrote:
>> +#ifdef CONFIG_FSL_BOOKE
>> + return put_user(period_to_sec(booke_wdt_period), p);
>> +#else
>
> period_to_sec() returns an unsigned long long, which means that the driver
> will write 8 bytes instead of 4 to user space.
Ok, I take that back. put_user() uses the size of the pointer, which
makes more sense anyway.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-01-27 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 19:24 [PATCH] watchdog: fix GETTIMEOUT ioctl in booke_wdt Dmitry Artamonow
2012-01-27 21:08 ` Timur Tabi
2012-01-27 21:22 ` Timur Tabi [this message]
2012-01-27 21:34 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2315B0.2010507@freescale.com \
--to=timur@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mad_soft@inbox.ru \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).