From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753912Ab2A3Hf5 (ORCPT ); Mon, 30 Jan 2012 02:35:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53689 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752615Ab2A3Hf4 (ORCPT ); Mon, 30 Jan 2012 02:35:56 -0500 Message-ID: <4F2648F5.5000908@redhat.com> Date: Mon, 30 Jan 2012 15:38:29 +0800 From: Dave Young User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110323 Thunderbird/3.1.9 MIME-Version: 1.0 To: Rusty Russell CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] add kernel parameter to disable module load References: <20120128033450.GA2138@darkstar> <87vcnvbab1.fsf@rustcorp.com.au> In-Reply-To: <87vcnvbab1.fsf@rustcorp.com.au> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/29/2012 08:51 AM, Rusty Russell wrote: > On Sat, 28 Jan 2012 11:34:50 +0800, Dave Young wrote: >> Sometimes we need to test a kernel of same version with code or config >> option changes. >> >> We already have sysctl to disable module load, but add a kernel >> parameter will be more convenient. > > >> +static int __init module_load_disable(char *str) >> +{ >> + modules_disabled = 1; >> + return 1; >> +} >> +__setup("nomodule", module_load_disable); > > You misspelled core_param here :) Thanks for review, will update to use core_param -- Thanks Dave