From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753176Ab2A3OBt (ORCPT ); Mon, 30 Jan 2012 09:01:49 -0500 Received: from mail.lippert-at.com ([62.80.22.186]:14819 "EHLO domex.lippertembedded.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753019Ab2A3OBs (ORCPT ); Mon, 30 Jan 2012 09:01:48 -0500 Message-ID: <4F26A228.4030106@LiPPERTEmbedded.de> Date: Mon, 30 Jan 2012 14:59:04 +0100 From: Jens Rottmann User-Agent: Thunderbird 1.5.0.14 (Windows/20071210) MIME-Version: 1.0 To: Thomas Gleixner , John Stultz CC: Andres Salomon , linux-kernel@vger.kernel.org, linux-geode@lists.infradead.org Subject: [PATCH] cs5535-clockevt: allow the MFGPT IRQ to be shared References: <4EE620A5.7080402@LiPPERTEmbedded.de> <20111212123131.502be350@queued.net> <4EE77416.8090907@LiPPERTEmbedded.de> <4EE8ECF3.6000900@LiPPERTEmbedded.de> <20111214104724.292b02d4@queued.net> In-Reply-To: <20111214104724.292b02d4@queued.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 30 Jan 2012 14:01:43.0996 (UTC) FILETIME=[B2B077C0:01CCDF57] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cs5535-clockevt: allow the MFGPT IRQ to be shared Shared timer IRQs are not a good solution, however the Geode platform has no APIC, IRQs are a scarce resource and there is no technical reason to forbid it rightaway. Increased latencies and overhead due to sharing are still better than a driver refusing to load. Signed-off-by: Jens Rottmann Acked-by: Andres Salomon --- Hi, could you please take this, for linux-next? Thanks, Jens --- linux-3.2-rc6/drivers/clocksource/cs5535-clockevt.c +++ allow_shared_mfgpt_irq/drivers/clocksource/cs5535-clockevt.c @@ -133,7 +133,7 @@ static irqreturn_t mfgpt_tick(int irq, v static struct irqaction mfgptirq = { .handler = mfgpt_tick, - .flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER, + .flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER | IRQF_SHARED, .name = DRV_NAME, }; _