From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: Eric B Munson <emunson@mgebm.net>,
mingo@redhat.com, hpa@zytor.com, ryanh@linux.vnet.ibm.com,
aliguori@us.ibm.com, mtosatti@redhat.com,
jeremy.fitzhardinge@citrix.com, kvm@vger.kernel.org,
linux-arch@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4 V10] Add ioctl for KVMCLOCK_GUEST_STOPPED
Date: Mon, 30 Jan 2012 17:18:52 +0100 [thread overview]
Message-ID: <4F26C2EC.5070303@siemens.com> (raw)
In-Reply-To: <4F26B220.9050101@redhat.com>
On 2012-01-30 16:07, Avi Kivity wrote:
> On 01/17/2012 08:40 PM, Eric B Munson wrote:
>> Now that we have a flag that will tell the guest it was suspended, create an
>> interface for that communication using a KVM ioctl.
>>
>>
>> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
>> index e1d94bf..1931e5c 100644
>> --- a/Documentation/virtual/kvm/api.txt
>> +++ b/Documentation/virtual/kvm/api.txt
>> @@ -1491,6 +1491,19 @@ following algorithm:
>> Some guests configure the LINT1 NMI input to cause a panic, aiding in
>> debugging.
>>
>> +4.65 KVMCLOCK_GUEST_PAUSED
>> +
>> +Capability: KVM_CAP_GUEST_PAUSED
>> +Architechtures: Any that implement pvclocks (currently x86 only)
>> +Type: vcpu ioctl
>
> vm ioctl.
>
>> +Parameters: None
>> +Returns: 0 on success, -1 on error
>> +
>> +This signals to the host kernel that the specified guest is being paused by
>> +userspace. The host will set a flag in the pvclock structure that is checked
>> +from the soft lockup watchdog. This ioctl can be called during pause or
>> +unpause.
>> +
>> 5. The kvm_run structure
>>
>>
>> +/*
>> + * kvm_set_guest_paused() indicates to the guest kernel that it has been
>> + * stopped by the hypervisor. This function will be called from the host only.
>> + */
>> +static int kvm_set_guest_paused(struct kvm *kvm)
>> +{
>> + struct kvm_vcpu *vcpu;
>> + struct pvclock_vcpu_time_info *src;
>> + int i;
>> +
>> + kvm_for_each_vcpu(i, vcpu, kvm) {
>> + if (!vcpu->arch.time_page)
>> + continue;
>> + src = &vcpu->arch.hv_clock;
>> + src->flags |= PVCLOCK_GUEST_STOPPED;
>
> This looks racy. The vcpu can remove its kvmclock concurrently with
> this access, and src will be NULL.
There is no race here (src is member of the vcpu), but arch.time might
have become invalid. KVM_REQ_CLOCK_UPDATE instead of mark_page_dirty
would indeed be the way to go. Trivial solution, I would say.
However, the concept of "guest stopped" has VM, not VCPU scope. That
makes the call more appropriate as a VM ioctl. If that thing should
really become per-vcpu, at least call it KVMCLOCK_VCPU_STOPPED.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-01-30 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1326825641-15765-1-git-send-email-emunson@mgebm.net>
2012-01-17 18:40 ` [PATCH 1/4 V10] Add flag to indicate that a vm was stopped by the host Eric B Munson
2012-01-17 18:40 ` [PATCH 2/4 V10] Add functions to check if the host has stopped the vm Eric B Munson
2012-01-17 18:40 ` [PATCH 3/4 V10] Add ioctl for KVMCLOCK_GUEST_STOPPED Eric B Munson
2012-01-30 15:07 ` Avi Kivity
2012-01-30 15:11 ` Avi Kivity
2012-01-30 15:33 ` Eric B Munson
2012-01-30 15:32 ` Eric B Munson
2012-01-30 15:49 ` Avi Kivity
2012-01-30 16:01 ` Eric B Munson
2012-01-30 16:18 ` Jan Kiszka [this message]
2012-01-30 17:11 ` Avi Kivity
2012-01-17 18:40 ` [PATCH 4/4 V10] Add check for suspended vm in softlockup detector Eric B Munson
2012-01-27 20:45 ` [PATCH 0/4 V10] Avoid soft lockup message when KVM is stopped by host Eric B Munson
2012-01-30 15:08 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F26C2EC.5070303@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=emunson@mgebm.net \
--cc=hpa@zytor.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=ryanh@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).