From: Dave Young <dyoung@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add kernel parameter to disable module load
Date: Tue, 31 Jan 2012 10:44:50 +0800 [thread overview]
Message-ID: <4F2755A2.5040108@redhat.com> (raw)
In-Reply-To: <87vcnvbab1.fsf@rustcorp.com.au>
On 01/29/2012 08:51 AM, Rusty Russell wrote:
> On Sat, 28 Jan 2012 11:34:50 +0800, Dave Young <dyoung@redhat.com> wrote:
>> Sometimes we need to test a kernel of same version with code or config
>> option changes.
>>
>> We already have sysctl to disable module load, but add a kernel
>> parameter will be more convenient.
>
>
>> +static int __init module_load_disable(char *str)
>> +{
>> + modules_disabled = 1;
>> + return 1;
>> +}
>> +__setup("nomodule", module_load_disable);
>
> You misspelled core_param here :)
>
Hello Rusty, If use core_param I'd better to change modules_disabled
from int to bool or we must pass nomodule=1 instead of simply pass
nomodule. But I think I can firstly post the core_param patch with
current int type, then work on the transition patch for the variable
type changes, what do you think?
Another do you think we need to expose this to sysfs via core_param?
According to the sysctl code looks like we should not add sysfs
interface to allow transition from "1" to "0"
--
Thanks
Dave
next prev parent reply other threads:[~2012-01-31 2:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 3:34 [PATCH] add kernel parameter to disable module load Dave Young
2012-01-29 0:51 ` Rusty Russell
2012-01-30 7:38 ` Dave Young
2012-01-31 2:44 ` Dave Young [this message]
2012-01-31 2:59 ` Rusty Russell
2012-01-31 3:36 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2755A2.5040108@redhat.com \
--to=dyoung@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).