From: Cong Wang <xiyou.wangcong@gmail.com>
To: Dave Young <dyoung@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] move vm tools from Documentation/vm/ to tools/
Date: Wed, 01 Feb 2012 14:45:47 +0800 [thread overview]
Message-ID: <4F28DF9B.40702@gmail.com> (raw)
In-Reply-To: <20120201063420.GA10204@darkstar.nay.redhat.com>
On 02/01/2012 02:34 PM, Dave Young wrote:
> tools/ is the better place for vm tools which are used by many people.
> Moving them to tools also make them open to more users instead of hide in
> Documentation folder.
Well, hugepage-mmap, hugepage-shm, and map_hugetlb are examples, not
really tools. So, only page-types is probably a tool, but I leave this
to Fengguang to decide.
>
> Also fixed several coding style problem.
Make it another patch for people to review. :)
[...]
> diff --git a/tools/vm/Makefile b/tools/vm/Makefile
> new file mode 100644
> index 0000000..b4f9fdd
> --- /dev/null
> +++ b/tools/vm/Makefile
> @@ -0,0 +1,11 @@
> +# Makefile for vm tools
> +
> +CC = $(CROSS_COMPILE)gcc
> +CFLAGS = -Wall -Wextra
> +
> +all: page-types hugepage-mmap hugepage-shm map_hugetlb
> +%: %.c
> + $(CC) $(CFLAGS) -o $@ $^
> +
> +clean:
> + $(RM) page-types hugepage-mmap hugepage-shm map_hugetlb
Is $(RM) defined?
next prev parent reply other threads:[~2012-02-01 6:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 6:34 [PATCH] move vm tools from Documentation/vm/ to tools/ Dave Young
2012-02-01 6:45 ` Cong Wang [this message]
2012-02-01 7:39 ` Dave Young
2012-02-01 7:32 ` Pekka Enberg
2012-02-01 7:41 ` Dave Young
2012-02-01 8:30 ` Wu Fengguang
2012-02-01 8:44 ` Pekka Enberg
2012-02-01 9:53 ` Dave Young
2012-02-01 9:53 ` Dave Young
2012-02-01 14:40 ` Christoph Lameter
2012-02-01 21:17 ` Andrew Morton
2012-02-02 2:13 ` Dave Young
2012-02-02 7:32 ` Cong Wang
2012-02-02 19:58 ` Andrew Morton
2012-02-02 19:56 ` Andrew Morton
2012-02-03 1:31 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F28DF9B.40702@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=dyoung@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).