From: Maxime Coquelin <maxime.coquelin@stericsson.com>
To: Linus WALLEIJ <linus.walleij@stericsson.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alex MACRO <alex.macro@stericsson.com>,
Michel JAOUEN <michel.jaouen@stericsson.com>
Subject: Re: [PATCH 1/4] mfd/ab8500: fix error path bug
Date: Wed, 1 Feb 2012 17:24:01 +0100 [thread overview]
Message-ID: <4F296721.5040203@stericsson.com> (raw)
In-Reply-To: <1328112555-32459-1-git-send-email-linus.walleij@stericsson.com>
Hi Linus,
On 02/01/2012 05:09 PM, Linus WALLEIJ wrote:
> From: Linus Walleij<linus.walleij@linaro.org>
>
> We were not freeing the irq properly in the error path in
> the AB8500 driver.
>
> Cc: Mark Brown<broonie@opensource.wolfsonmicro.com>
> Signed-off-by: Maxime Coquelin<maxime.coquelin@stericsson.com>
> Signed-off-by: Alex Macro<alex.macro@stericsson.com>
> Signed-off-by: Michel Jaouen<michel.jaouen@stericsson.com>
> Signed-off-by: Linus Walleij<linus.walleij@linaro.org>
> ---
> drivers/mfd/ab8500-core.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
> index 53e2a80..bf823d2 100644
> --- a/drivers/mfd/ab8500-core.c
> +++ b/drivers/mfd/ab8500-core.c
> @@ -956,9 +956,10 @@ int __devinit ab8500_init(struct ab8500 *ab8500)
> return ret;
>
> out_freeirq:
> - if (ab8500->irq_base) {
> + if (ab8500->irq_base)
> free_irq(ab8500->irq, ab8500);
> out_removeirq:
> + if (ab8500->irq_base)
> ab8500_irq_remove(ab8500);
> }
Shouldn't the above brace to be removed?
> return ret;
Regards,
Maxime
next prev parent reply other threads:[~2012-02-01 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 16:09 [PATCH 1/4] mfd/ab8500: fix error path bug Linus Walleij
2012-02-01 16:24 ` Maxime Coquelin [this message]
2012-02-01 20:28 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F296721.5040203@stericsson.com \
--to=maxime.coquelin@stericsson.com \
--cc=alex.macro@stericsson.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michel.jaouen@stericsson.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).