From: Darren Hart <dvhart@linux.intel.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Josh Boyer <jwboyer@redhat.com>, Michal Marek <mmarek@suse.cz>,
kernel-team@fedoraproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] merge_config.sh: Use the first file as the initial config
Date: Thu, 02 Feb 2012 12:37:12 -0800 [thread overview]
Message-ID: <4F2AF3F8.3040205@linux.intel.com> (raw)
In-Reply-To: <1328213697.2342.154.camel@work-vm>
On 02/02/2012 12:14 PM, John Stultz wrote:
> On Wed, 2012-02-01 at 12:01 -0500, Josh Boyer wrote:
>> Take the first config fragment and use it verbatim as the initial config set.
>> This avoids running the verification loop for the first file, as nothing has
>> actually been merged at this point. This significantly increases performance
>> for large config fragments.
>>
>> Signed-off-by: Josh Boyer <jwboyer@redhat.com>
>> ---
>>
>> When experimenting with merge_config.sh on the Fedora config fragments, this
>> cut the execution time of a single invocation with all the config fragments
>> in half (from 28 seconds to 13 seconds).
>
> Adding Darren to the CC.
>
> Nice! Looks ok to me.
>
> Acked-by: John Stultz <john.stultz@linaro.org>
Thanks Josh,
Acked-by: Darren Hart <dvhart@linux.intel.com>
>
>> scripts/kconfig/merge_config.sh | 6 +++++-
>> 1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
>> index ceadf0e..23d738a 100644
>> --- a/scripts/kconfig/merge_config.sh
>> +++ b/scripts/kconfig/merge_config.sh
>> @@ -58,12 +58,16 @@ while true; do
>> esac
>> done
>>
>> -
>> +INITFILE=$1
>> +shift;
>>
>> MERGE_LIST=$*
>> SED_CONFIG_EXP="s/^\(# \)\{0,1\}\(CONFIG_[a-zA-Z0-9_]*\)[= ].*/\2/p"
>> TMP_FILE=$(mktemp ./.tmp.config.XXXXXXXXXX)
>>
>> +echo "Using $INITFILE as base"
>> +cat $INITFILE > $TMP_FILE
>> +
>> # Merge files, printing warnings on overrided values
>> for MERGE_FILE in $MERGE_LIST ; do
>> echo "Merging $MERGE_FILE"
>
>
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
next prev parent reply other threads:[~2012-02-02 20:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 17:01 [PATCH] merge_config.sh: Use the first file as the initial config Josh Boyer
2012-02-02 20:14 ` John Stultz
2012-02-02 20:37 ` Darren Hart [this message]
2012-03-24 22:26 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2AF3F8.3040205@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=jwboyer@redhat.com \
--cc=kernel-team@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).