From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755988Ab2BCD0w (ORCPT ); Thu, 2 Feb 2012 22:26:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11368 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754523Ab2BCD0u (ORCPT ); Thu, 2 Feb 2012 22:26:50 -0500 Message-ID: <4F2B53F1.6080405@redhat.com> Date: Fri, 03 Feb 2012 11:26:41 +0800 From: Jason Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111229 Thunderbird/9.0 MIME-Version: 1.0 To: Jason Wang CC: netdev@vger.kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, glommer@parallels.com, mst@redhat.com Subject: Re: [v3.3-rc2+ PATCH] tcp: properly initialize tcp memory limits References: <20120202100700.38694.80000.stgit@amd-6168-8-1.englab.nay.redhat.com> In-Reply-To: <20120202100700.38694.80000.stgit@amd-6168-8-1.englab.nay.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2012 06:07 PM, Jason Wang wrote: > Commit 4acb4190 tries to fix the using uninitialized value > introduced by commit 3dc43e3, but it would make the > per-socket memory limits too small. > > This patch fixes this and also remove the redundant codes > introduced in 4acb4190. > > Signed-off-by: Jason Wang > --- Just FYI, this fix the tcp performance regression, I test the virtio-net tcp performance: without this patch: [root@amd-6168-8-1 net-next]# netperf -H 192.168.100.4 -t TCP_MAERTS TCP MAERTS TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to 192.168.100.4 (192.168.100.4) port 0 AF_INET Recv Send Send Socket Socket Message Elapsed Size Size Size Time Throughput bytes bytes bytes secs. 10^6bits/sec 87380 16384 16384 10.00 5997.95 with this patch: [root@amd-6168-8-1 net-next]# netperf -H 192.168.100.4 -t TCP_MAERTS TCP MAERTS TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to 192.168.100.4 (192.168.100.4) port 0 AF_INET Recv Send Send Socket Socket Message Elapsed Size Size Size Time Throughput bytes bytes bytes secs. 10^6bits/sec 87380 16384 16384 10.00 9670.98